Refactor saved object management registry usage

[kertal]

Summary

Management will continue to use the SavedObjectManagementRegistry for a while. However, the way it's currently used isn't necessary any more. The SavedObjectLoader services first had to be registered in the global Angular, the ids were saved in the registry. For use in Management, the services where retrieved from the global angular. This PR now registers the services directly, removes global angular registration of SavedObjectLoader servives in discover / visualize / dashboard. Timelion still needs the SavedObjectLoader registered in Angular at the moment.

Since savedSearches is no longer registered in Angular by Discover, I've also converted the last client, thetransform plugin, to get this service by calling the createSavedSearchesService function that the discover plugin offers instead.

Dev docs

Registration of the following SavedObjectLoader in Angular was removed:

• savedSearches
• savedVisualizations
• savedDashboard

The plugins now provide the functions to create a SavedObjectLoader service, here's an example how the services are created now:

import { createSavedSearchesService } from '../discover';
import { TypesService, createSavedVisLoader } from '../../../visualizations/public';
import { createSavedDashboardLoader } from '../dashboard';

const services = {
   savedObjectsClient: npStart.core.savedObjects.client,
   indexPatterns: npStart.plugins.data.indexPatterns,
   chrome: npStart.core.chrome,
   overlays: npStart.core.overlays,
 };

const servicesForVisualizations = {
    ...services,
    ...{ visualizationTypes: new TypesService().start() },
  }

const savedSearches = createSavedSearchesService(services);
const savedVisualizations = createSavedVisLoader(servicesForVisualizations);
const savedDashboards = createSavedDashboardLoader(services);

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately

• This includes a feature addition or change that requires a release note and was labeled appropriately

[flash1293]

Code LGTM, didn't test locally. This change might be worth a dev doc section.

[kertal]

thx for the review dear @flash1292 and I do agree, there should be a dev doc section about this change 👍

[lizozom]

@elasticmachine merge upstream

[lizozom]

Tested transform, saved objects management and timelion on Ubuntu \ Chrome
Overall code seems LGTM.
Added a couple of comments.

[walterra]

Thanks for doing the transform plugin changes. Code LGTM, also tested a local checkout.

[kertal]

thx @flash1293 , @lizozom , @walterra for your reviews 🙇 . @lizozom , I'll address you're useful hints soon

[ppisljar]

code lgtm, thanks for moving saved vis stuff to visualizations plugin!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c0067da

History

• 💚 Build #22400 succeeded 4eed031
• 💔 Build #22378 failed 2040176
• 💔 Build #22337 failed 522c197
• 💔 Build #20575 failed 22f586e
• 💚 Build #19788 succeeded b2208cc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream