[Endpoint] EMT-65:always return accurate endpoint count #54423

nnamdifrankie · 2020-01-10T02:48:40Z

Summary

Handle the case when the paging property requested uses a page index that is greater than the number of documents in the index. Ensure that the accurate aggregated number of endpoints in the index is returned and added test to confirm it.
Added test for expected result when index is empty, confirm that 0 is returned as the total.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~

Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

nnamdifrankie · 2020-01-10T02:49:36Z

@elasticmachine merge upstream

nnamdifrankie · 2020-01-10T05:30:00Z

@elasticmachine merge upstream

pzl · 2020-01-10T13:51:04Z

x-pack/plugins/endpoint/server/routes/endpoints.ts

@@ -66,6 +66,10 @@ function mapToEndpointResultList(
  queryParams: Record<string, any>,
  searchResponse: SearchResponse<EndpointData>
 ): EndpointResultList {
+  let totalNumberOfEndpoints = 0;


let totalNumberOfEndpoints = searchResponse?.aggregations?.total?.value || 0;

Would that work here?

Yes, slipped me to use this shorthand. Thanks.

oatkiller · 2020-01-10T14:29:09Z

x-pack/test/api_integration/apis/endpoint/endpoints.ts

-    describe('GET /api/endpoint/endpoints', () => {
+    describe('POST /api/endpoint/endpoints when index is empty', () => {
+      it('endpoints api should return empty result when index is empty', async () => {
+        await esArchiver.unload('endpoint/endpoints');


…b.com:nnamdifrankie/kibana into EMT-65_always_return_accurate_total_endpoints

EMT-65:always return accurate endpoint count, independent of paging properties

kibanamachine · 2020-01-13T21:45:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8d5aaf1

History

💚 Build #19299 succeeded 8d5aaf1
💚 Build #19187 succeeded 5671a43
💔 Build #19184 failed 1bd1fb5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Add Endpoint plugin and Resolver embeddable (#51994) * Add functional tests for plugins to x-pack (so we can do a functional test of the Resolver embeddable) * Add Endpoint plugin * Add Resolver embeddable * Test that Resolver embeddable can be rendered Conflicts: x-pack/.i18nrc.json x-pack/test/api_integration/apis/index.js * [Endpoint] Register endpoint app (#53527) * register app, create functional test * formatting * update tests * adjust test data for endpoint * add endpoint tests for testing spaces, app enabled, disabled, etc * linting * add read privileges to endpoint * rename variable since its used now * remove deprecated context * remove unused variable * fix type check * correct test suite message Co-Authored-By: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * [Endpoint] add react router to endpoint app (#53808) * add react router to endpoint app * linting * linting * linting * correct tests * change history from hash to browser, add new test util * remove default values in helper functions * fix type check, use FunctionComponent as oppsed to FC * use BrowserRouter component * use BrowserRouter component lin * add comments to test framework, change function name to include browserHistory Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * EMT-issue-65: add endpoint list api (#53861) add endpoint list api * EMT-65:always return accurate endpoint count (#54423) EMT-65:always return accurate endpoint count, independent of paging properties * Resolver component w/ sample data (#53619) Resolver is a map. It shows processes that ran on a computer. The processes are drawn as nodes and lines connect processes with their parents. Resolver is not yet implemented in Kibana. This PR adds a 'map' type UX. The user can click and drag to pan the map and zoom using trackpad pinching (or ctrl and mousewheel.) There is no code providing actual data. Sample data is included. The sample data is used to draw a map. The fundamental info needed is: process names the parent of a process With this info we can topologically lay out the processes. The sample data isn't yet in a realistic format. We'll be fixing that soon. Related issue: elastic/endpoint-app-team#30 * Resolver test plugin not using mount context. (#54933) Mount context was deprecated. Use core.getStartServices() instead. * Resolver nonlinear zoom (#54936) * [Endpoint] add Redux saga Middleware and app Store (#53906) * Added saga library * Initialize endpoint app redux store * Resolver is overflow: hidden to prevent obscured elements from showing up (#55076) * [Endpoint] Fix saga to start only after store is created and stopped on app unmount (#55245) - added `stop()`/`start()` methods to the Saga Middleware creator factory - adjust tests based on changes - changed application `renderApp` to stop sagas when react app is unmounted * Resolver zoom, pan, and center controls (#55221) * Resolver zoom, pan, and center controls * add tests, fix north panning * fix type issue * update west and east panning to behave like google maps * [Endpoint] FIX: Increase tests `sleep` default duration back to 100ms (#55492) Revert `sleep()` default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs. Fixes #55464 Fixes #55465 * [Endpoint] EMT-65: make endpoint data types common, restructure (#54772) [Endpoint] EMT-65: make endpoint data types common, use schema changes * Basic Functionality Alert List (#55800) * sets up initial grid and data type * data feeds in from backend but doesnt update * sample data feeding in correctly * Fix combineReducers issue by importing Redux type from 'redux' package * Add usePageId hook that fires action when user navigates to page * Strict typing for middleware * addresses comments and uses better types * move types to common/types.ts * Move types to endpoint/types.ts, address PR comments blah 2 Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> * [Endpoint] Add Endpoint Details route (#55746) * Add Endpoint Details route * add Endpoint Details tests * sacrifices to the Type gods * update to latest endpoint schema Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] EMT-67: add kql support for endpoint list (#56328) [Endpoint] EMT-67: add kql support for endpoint list * [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (#56538) * ERT-82 ERT-83 ERT-84 (partial): Add Alert List API with pagination * Better type safety for alert list API * Add Test to Verify Endpoint App Landing Page (#57129) Conflicts: x-pack/test/functional/page_objects/index.ts * fixes render bug in alert list (#57152) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver: Animate camera, add sidebar (#55590) This PR adds a sidebar navigation. clicking the icons in the nav will focus the camera on the different nodes. There is an animation effect when the camera moves. Conflicts: yarn.lock * [Endpoint] Task/basic endpoint list (#55623) * Adds host management list to endpoint security plugin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] Policy List UI route and initial view (#56918) * Initial Policy List view * Add `endpoint/policy` route and displays Policy List * test cases (both unit and functional) Does not yet interact with API (Ingest). * Add ApplicationService app status management (#50223) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * Implements `getStartServices` on server-side (#55156) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * [ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib (#56957) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: nnamdifrankie <56440728+nnamdifrankie@users.noreply.github.com> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> Co-authored-by: Dan Panzarella <pzl@users.noreply.github.com> Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com> Co-authored-by: Charlie Pichette <56399229+charlie-pichette@users.noreply.github.com> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

EMT-65:always return accurate endpoint count

64d23a9

nnamdifrankie added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 10, 2020

Merge branch 'master' into EMT-65_always_return_accurate_total_endpoints

1bd1fb5

Merge branch 'master' into EMT-65_always_return_accurate_total_endpoints

5671a43

pzl reviewed Jan 10, 2020

View reviewed changes

pzl approved these changes Jan 10, 2020

View reviewed changes

oatkiller reviewed Jan 10, 2020

View reviewed changes

oatkiller approved these changes Jan 10, 2020

View reviewed changes

nnamdifrankie added 2 commits January 10, 2020 09:48

EMT-65:use shortened form

ed13c0c

Merge branch 'EMT-65_always_return_accurate_total_endpoints' of githu…

8d5aaf1

…b.com:nnamdifrankie/kibana into EMT-65_always_return_accurate_total_endpoints

james-elastic approved these changes Jan 10, 2020

View reviewed changes

nnamdifrankie merged commit 1d4c2f6 into elastic:master Jan 10, 2020

nnamdifrankie deleted the EMT-65_always_return_accurate_total_endpoints branch January 10, 2020 16:08

thomasneirynck pushed a commit to thomasneirynck/kibana that referenced this pull request Jan 12, 2020

EMT-65:always return accurate endpoint count (elastic#54423)

2da11f5

EMT-65:always return accurate endpoint count, independent of paging properties

kevinlog added Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Endpoint Management Team:Endpoint Response Endpoint Response Team labels Jan 13, 2020

kevinlog changed the title ~~EMT-65:always return accurate endpoint count~~ [Endpoint] EMT-65:always return accurate endpoint count Jan 13, 2020

kevinlog added the Feature:Endpoint Elastic Endpoint feature label Feb 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Endpoint] EMT-65:always return accurate endpoint count #54423

[Endpoint] EMT-65:always return accurate endpoint count #54423

nnamdifrankie commented Jan 10, 2020 •

edited

Loading

nnamdifrankie commented Jan 10, 2020

nnamdifrankie commented Jan 10, 2020

pzl Jan 10, 2020

nnamdifrankie Jan 10, 2020

oatkiller Jan 10, 2020

kibanamachine commented Jan 13, 2020

[Endpoint] EMT-65:always return accurate endpoint count #54423

[Endpoint] EMT-65:always return accurate endpoint count #54423

Conversation

nnamdifrankie commented Jan 10, 2020 • edited Loading

Summary

Checklist

For maintainers

nnamdifrankie commented Jan 10, 2020

nnamdifrankie commented Jan 10, 2020

pzl Jan 10, 2020

Choose a reason for hiding this comment

nnamdifrankie Jan 10, 2020

Choose a reason for hiding this comment

oatkiller Jan 10, 2020

Choose a reason for hiding this comment

kibanamachine commented Jan 13, 2020

💚 Build Succeeded

History

nnamdifrankie commented Jan 10, 2020 •

edited

Loading