Functional tests: refactor dashboard_page #54588

dmlemeshko · 2020-01-13T15:32:04Z

The follow-up to #53845 that closes the first item in #53117 to improve the developer's experience in writing functional tests.

Common actions between landing pages of Visualize and Dashboard are move to listingTable service, duplicated code is deleted. dashboard_page contains only Dashboard-specific actions.

dmlemeshko · 2020-01-13T18:35:54Z

@elasticmachine merge upstream

dmlemeshko · 2020-01-14T06:49:32Z

@elasticmachine merge upstream

dmlemeshko · 2020-01-14T08:20:20Z

@elasticmachine merge upstream

dmlemeshko · 2020-01-14T11:26:02Z

@elasticmachine merge upstream

kibanamachine · 2020-01-14T12:43:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3cbf5a2

History

💔 Build #20047 failed e3b0114
💚 Build #20038 succeeded 3361560
💔 Build #19873 failed ecda7c0
💚 Build #19831 succeeded b0a4400
💔 Build #19784 failed 1e69c36

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dmlemeshko · 2020-01-14T14:41:57Z

Last 2 failures were not caused by my changes:

Build Custom Background Sets for Significant Term Queries #20047 failed: Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded

[00:06:28]                 │ info [logstash_functional] Loading "mappings.json"
[00:06:28]                 │ info [logstash_functional] Loading "data.json.gz"
[00:06:28]                 │ info [o.e.a.s.m.TransportMasterNodeAction] [kibana-ci-immutable-centos-tests-xl-1578990066669365586] unexpected exception during publication
[00:06:28]                 │      org.elasticsearch.ResourceAlreadyExistsException: index [logstash-2015.09.22/4LxmCUfQSXWZrc6Y7AGucA] already exists
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validateIndexName(MetaDataCreateIndexService.java:147) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validate(MetaDataCreateIndexService.java:616) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService$IndexCreationTask.execute(MetaDataCreateIndexService.java:291) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:47) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:697) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:319) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.runTasks(MasterService.java:214) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService$Batcher.run(MasterService.java:151) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:188) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:699) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:252) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:215) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:06:28]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:06:28]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:06:28]                 │ info [o.e.a.s.m.TransportMasterNodeAction] [kibana-ci-immutable-centos-tests-xl-1578990066669365586] unexpected exception during publication
[00:06:28]                 │      org.elasticsearch.ResourceAlreadyExistsException: index [logstash-2015.09.20/1mtDU8UbTJCZCw5u_Bn_KQ] already exists
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validateIndexName(MetaDataCreateIndexService.java:147) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validate(MetaDataCreateIndexService.java:616) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService$IndexCreationTask.execute(MetaDataCreateIndexService.java:291) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:47) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:697) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:319) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.runTasks(MasterService.java:214) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService$Batcher.run(MasterService.java:151) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:188) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:699) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:252) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:215) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:06:28]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]
[00:06:28]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:06:28]                 │ info [o.e.a.s.m.TransportMasterNodeAction] [kibana-ci-immutable-centos-tests-xl-1578990066669365586] unexpected exception during publication
[00:06:28]                 │      org.elasticsearch.ResourceAlreadyExistsException: index [logstash-2015.09.21/PQQkUZMNQPiNriZ1RTfwlQ] already exists
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validateIndexName(MetaDataCreateIndexService.java:147) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService.validate(MetaDataCreateIndexService.java:616) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.metadata.MetaDataCreateIndexService$IndexCreationTask.execute(MetaDataCreateIndexService.java:291) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:47) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:697) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:319) ~[elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService.runTasks(MasterService.java:214) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.MasterService$Batcher.run(MasterService.java:151) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:150) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:188) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:699) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:252) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:215) [elasticsearch-8.0.0-SNAPSHOT.jar:8.0.0-SNAPSHOT]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
[00:06:28]                 │      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
[00:06:28]                 │      	at java.lang.Thread.run(Thread.java:830) [?:?]

- Build #19873 failed: Jest tests were not touch by PR - Kibana Pipeline / x-pack-intake-agent / x-pack-intake / X-Pack Jest Tests.x-pack/legacy/plugins/alerting/server/task_runner.Task Runner recovers gracefully when the Alert Task Runner throws an exception when fetching the encrypted attributes - Kibana Pipeline / x-pack-intake-agent / x-pack-intake / X-Pack Jest Tests.x-pack/legacy/plugins/alerting/server/task_runner.Task Runner recovers gracefully when the Alert Task Runner throws an exception when getting internal Services - Kibana Pipeline / x-pack-intake-agent / x-pack-intake / X-Pack Jest Tests.x-pack/legacy/plugins/alerting/server/task_runner.Task Runner recovers gracefully when the Alert Task Runner throws an exception when fetching attributes

wayneseymour · 2020-01-14T15:29:28Z

test/functional/page_objects/time_picker.js

+
+    async setLogstashDataRange() {
+      const fromTime = 'Apr 9, 2018 @ 00:00:00.000';
+      const toTime = 'Apr 13, 2018 @ 00:00:00.000';


Why these dates in this fn, and the previous fn?

It was transferred from dashboard_page.js because it is not dashboard action, but time picker. There are 3 of these functions and they set an interval according to data in ES archivers.

wayneseymour

LGTM

* [test/functional] cleanup & tsfy dashboard_page * fix & improvement Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [test/functional] cleanup & tsfy dashboard_page * fix & improvement Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [test/functional] cleanup & tsfy dashboard_page * fix & improvement Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

dmlemeshko added 2 commits January 13, 2020 18:24

[test/functional] cleanup & tsfy dashboard_page

1e69c36

fix & improvement

b0a4400

Merge branch 'master' into func-tests/refactor-dashboard-page

ecda7c0

dmlemeshko added the test_ui_functional label Jan 13, 2020

dmlemeshko requested review from wayneseymour and LeeDr January 13, 2020 18:37

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Jan 13, 2020

Merge branch 'master' into func-tests/refactor-dashboard-page

3361560

Merge branch 'master' into func-tests/refactor-dashboard-page

e3b0114

dmlemeshko marked this pull request as ready for review January 14, 2020 08:28

Merge branch 'master' into func-tests/refactor-dashboard-page

3cbf5a2

wayneseymour reviewed Jan 14, 2020

View reviewed changes

wayneseymour approved these changes Jan 14, 2020

View reviewed changes

dmlemeshko merged commit 040aee9 into elastic:master Jan 14, 2020

dmlemeshko added v7.6.0 and removed v7.7.0 labels Jan 14, 2020

dmlemeshko mentioned this pull request Jan 14, 2020

[7.x] Functional tests: refactor dashboard_page (#54588) #54750

Merged

flash1293 mentioned this pull request Feb 21, 2020

[test-failed]: Chrome UI Functional Tests.test/functional/apps/visualize/_pie_chart·js - visualize app pie chart split chart "before all" hook for "shows correct split chart" #51530

Closed

dmlemeshko deleted the func-tests/refactor-dashboard-page branch January 31, 2022 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Functional tests: refactor dashboard_page #54588

Functional tests: refactor dashboard_page #54588

dmlemeshko commented Jan 13, 2020

dmlemeshko commented Jan 13, 2020

dmlemeshko commented Jan 14, 2020

dmlemeshko commented Jan 14, 2020

dmlemeshko commented Jan 14, 2020

kibanamachine commented Jan 14, 2020

dmlemeshko commented Jan 14, 2020

wayneseymour Jan 14, 2020

dmlemeshko Jan 14, 2020

wayneseymour left a comment

Functional tests: refactor dashboard_page #54588

Functional tests: refactor dashboard_page #54588

Conversation

dmlemeshko commented Jan 13, 2020

dmlemeshko commented Jan 13, 2020

dmlemeshko commented Jan 14, 2020

dmlemeshko commented Jan 14, 2020

dmlemeshko commented Jan 14, 2020

kibanamachine commented Jan 14, 2020

💚 Build Succeeded

History

dmlemeshko commented Jan 14, 2020

wayneseymour Jan 14, 2020

Choose a reason for hiding this comment

dmlemeshko Jan 14, 2020

Choose a reason for hiding this comment

wayneseymour left a comment

Choose a reason for hiding this comment