Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Temporarily skip flakey tests #54675

Merged
merged 3 commits into from
Jan 14, 2020
Merged

[Uptime] Temporarily skip flakey tests #54675

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a757496
[Uptime] Temporarily skip flakey tests
andrewvc Jan 14, 2020
da6fb6f
Fix further flakey tests due to hardcoding times + using snapshots
andrewvc Jan 14, 2020
86aff94
Merge branch 'master' into temporarily-skip-flakey-tests
andrewvc Jan 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../uptime/public/components/functional/location_map/__tests__/location_status_tags.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import { renderWithIntl } from 'test_utils/enzyme_helpers';
import { MonitorLocation } from '../../../../../common/runtime_types/monitor';
import { LocationStatusTags } from '../';

describe('StatusByLocation component', () => {
// These tests use absolute time
describe.skip('StatusByLocation component', () => {
let monitorLocations: MonitorLocation[];

const start = moment('2020-01-10T12:22:32.567Z');
Expand Down
2 changes: 1 addition & 1 deletion .../public/components/functional/monitor_status_details/__test__/status_by_location.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { renderWithIntl } from 'test_utils/enzyme_helpers';
import { MonitorLocation } from '../../../../../common/runtime_types';
import { StatusByLocations } from '../';

describe('StatusByLocation component', () => {
describe.skip('StatusByLocation component', () => {
let monitorLocations: MonitorLocation[];

it('renders when up in all locations', () => {
Expand Down
6 changes: 4 additions & 2 deletions x-pack/test/functional/apps/uptime/overview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ export default ({ getPageObjects }: FtrProviderContext) => {
]);
});

it('pagination is cleared when filter criteria changes', async () => {
// flakey see https://github.com/elastic/kibana/issues/54527
it.skip('pagination is cleared when filter criteria changes', async () => {
await pageObjects.uptime.goToUptimePageAndSetDateRange(DEFAULT_DATE_START, DEFAULT_DATE_END);
await pageObjects.uptime.changePage('next');
// there should now be pagination data in the URL
Expand Down Expand Up @@ -86,7 +87,8 @@ export default ({ getPageObjects }: FtrProviderContext) => {
]);
});

describe('snapshot counts', () => {
// Flakey, see https://github.com/elastic/kibana/issues/54541
describe.skip('snapshot counts', () => {
it('updates the snapshot count when status filter is set to down', async () => {
await pageObjects.uptime.goToUptimePageAndSetDateRange(
DEFAULT_DATE_START,
Expand Down