Fix double fetch errors

[flash1293]

Fixes #54526

Additionally to the problem described in the ticket this also fixes the double fetch problem when adding/removing filter pills.

There are multiple ways fetch calls can reach the discover app:

• From a global state (e.g. timefilter) that got updated by something external
• From a react callback because the user changed timefilter/query in the UI
• From a query migration happening in a scope watcher

This PR attempts to fix those by only triggering a fetch if the time range doesn't change.

TODO:

• Fix double fetch on filter change. This is caused by src/plugins/data/public/query/filter_manager/lib/mappers/map_phrase.ts mapping a new formatter function into the filter object which causes the object to be non-equal to the current one on each update. Not sure what's the best way to fix this, plus we should have some way of testing this as I remember that we had a similar case in the past. cc @lizozom

[flash1293]

@lizozom Is the filter problem something we should solve in that PR or do you want me to open a separate issue?

[lizozom]

@flash1293 just create an issue and assign to me.

[lizozom]

Scary, but works :-D

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[flash1293]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 5e737aa

History

• 💚 Build #20128 succeeded b17556f
• 💚 Build #20079 succeeded 308caf8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream