Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hapi config] Set strict header to false. #5525

Closed
wants to merge 2 commits into from

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 30, 2015

This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.

Cookies that are not parsed correctly (document.cookie = '3') will still break.

#5436 (comment) has an example test case.

Closes #5436

This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.
@epixa
Copy link
Contributor

epixa commented Nov 30, 2015

Can you add a test for this modeled after that use case that you linked in the comment?

@epixa epixa assigned jbudz and unassigned epixa Nov 30, 2015
@jbudz jbudz added the v5.0.0 label Dec 1, 2015
@jbudz jbudz assigned epixa and unassigned jbudz Dec 1, 2015
@epixa
Copy link
Contributor

epixa commented Dec 1, 2015

LGTM

@epixa epixa assigned jbudz and unassigned epixa Dec 1, 2015
@elasticsearch-bot
Copy link

Jon Budzenski merged this into the following branches!

Branch Commits
master 10c40e7, 1633878
4.2 5ec754f, 9468af8
4.3 63e0d69, 39134f7
4.x f443664, c6a4ca7

jbudz added a commit that referenced this pull request Dec 1, 2015
This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.

Fixes #5525
jbudz added a commit that referenced this pull request Dec 1, 2015
jbudz added a commit that referenced this pull request Dec 1, 2015
This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.

Fixes #5525
jbudz added a commit that referenced this pull request Dec 1, 2015
jbudz added a commit that referenced this pull request Dec 1, 2015
This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.

Fixes #5525
jbudz added a commit that referenced this pull request Dec 1, 2015
@jbudz jbudz closed this in 10c40e7 Dec 1, 2015
jbudz added a commit that referenced this pull request Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants