New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hapi config] Set strict header to false. #5525
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the application continue loading if a request has a cookie that is in violation of RFC 6265.
Can you add a test for this modeled after that use case that you linked in the comment? |
LGTM |
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
This allows the application continue loading if a request has a cookie that is in violation of RFC 6265. Fixes #5525
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
This allows the application continue loading if a request has a cookie that is in violation of RFC 6265. Fixes #5525
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
This allows the application continue loading if a request has a cookie that is in violation of RFC 6265. Fixes #5525
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
jbudz
added a commit
that referenced
this pull request
Dec 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the application continue loading if a request has a cookie
that is in violation of RFC 6265.
Cookies that are not parsed correctly (
document.cookie = '3'
) will still break.#5436 (comment) has an example test case.
Closes #5436