[ML] Fixing ML's watcher integration #55439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
walterra,
darnautov,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 22, 2020
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jan 22, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 22, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: [Watcher] Add support for additional watch action statuses (elastic#55092) [ML] Fix entity controls update. (elastic#55524) [ML] Fixing ML's watcher integration (elastic#55439) [ML] Fixes permissions checks for data visualizer create job links (elastic#55431) [SearchProfiler] Move out of legacy (elastic#55331) # Conflicts: # x-pack/plugins/watcher/server/models/action_status/action_status.js
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
that referenced
this pull request
Jan 22, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jan 22, 2020
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Broken severity dropdown.
Recent appState changes have made the common severity selector incompatible with our watch creation UI. Rather than make changes to the common selector, it was safer to make a copy of the component which stores its state internally rather than in the appState.
also updates our http service to allow 204 responses. This was originally added to work around a breaking change to the create watch endpoint, which has subsequently been fixed by #55535.
This change will still be needed if we encounter any other 204 responses, so it is safer to leave it in.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately