[SearchProfiler] Fix handling of bad profile data and update tab behaviour

[jloleysens]

Summary

There is a less known feature of SearchProfiler that enables users to provide a profile response JSON object in the text editor. When they click "Profile" it detects the presence of profile data, short circuits the network requests and goes straight to rendering a profile tree.

It is not clear how many users actually use this functionality, given that it is not really advertised in the UI, but currently pasting a bad profile (malformed) into the SearchProfiler text editor and clicking profile crashes the app. Steps:

1. Open SearchProfiler
2. Paste { "profile": { "shards": [{}] } } into the text editor
3. Click "Profile"
4. See blank UI where SearchProfiler was.

This contribution adds a try..catch to prevent the UI from hard crashing.

This contribution also updates auto-setting of tabs under different conditions. If the user is viewing an aggregation, the UI shouldn't switch back to query if they submit another aggregation.

E.g.

{
    "aggs" : {
        "avg_grade" : { "avg" : { "field" : "grade" } }
    }
}

This bug should exist on previous Kibana versions too.

Release note

Fixed crash on bad profile data in SearchProfiler.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 300c0f9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[alisonelizabeth]

Code LGTM. Tested locally; confirmed fix and verified tab behavior. I think as an improvement to this (not blocking), it would be nice to render a callout message or something indicating the user provided bad profile data, rather than just an empty screen.

[cjcenizal]

TIL 💡