[export saved objects] Use scroll API when exporting all #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The elasticsearch-js client could really use a |
| return scanner.scanAndMap(queryString, { | ||
| pageSize, | ||
| docCount: Number.POSITIVE_INFINITY | ||
| }, this.mapHits.bind(this)); |
There was a problem hiding this comment.
please use (hit) => this.mapHits(hit) vs function binding
|
Is this fix not relevant to 4.2? If it is, it should be backported to that as well. |
|
Adding 4.2 label, good catch. Anything ES 2.1+ |
|
@jbudz This only supports es 2.1+? If so, it can't go into 4.2 (which is 2.0) |
|
|
|
Ignore my last comment - this will still work on es 2.0, it just wasn't an issue with 2.0. |
|
LGTM |
|
LFunctionallyGTM |
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
jbudz
added a commit
that referenced
this pull request
Dec 9, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export all is throwing errors because the default max window size was changed to 10k and we are using Math.pow(2, 31) - 1. Currently the search API is used, this adds and uses a scan method.
This could be refactored to a shared method, however it does follow the existing files as is. Throwing it up now for feedback, undecided how far to take it.
Other alternatives
Closes #5524