Add absolute option to ApplicationStart.getUrlForApp
#57193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
commented
Feb 10, 2020
Comment on lines
+373
to
+378
| function relativeToAbsolute(url: string) { | ||
| // convert all link urls to absolute urls | ||
| const a = document.createElement('a'); | ||
| a.setAttribute('href', url); | ||
| return a.href; | ||
| } |
There was a problem hiding this comment.
So, this implementation can seems strange, as it relies on actual DOM a node behavior, however
- This is the same approach that is currently used in
NavLinksto creates the absolute url - The behavior is specified, this is not relying on internal browser implementation
- This just works (tm), when other snippets to properly parse and convert a relative url to an absolute one are 'way' more complex, and requires to parse
window.locationto construct the url.
Still, tell me if we want to change the implementation
Comment on lines
591
to
599
| it('creates absolute URLs when `absolute` parameter is true', async () => { | ||
| service.setup(setupDeps); | ||
| const { getUrlForApp } = await service.start(startDeps); | ||
|
|
||
| expect(getUrlForApp('app1', { absolute: true })).toBe('http://localhost/app/app1'); | ||
| expect(getUrlForApp('app2', { path: 'deep/link', absolute: true })).toBe( | ||
| 'http://localhost/app/app2/deep/link' | ||
| ); | ||
| }); |
There was a problem hiding this comment.
Because of current implementation, we cannot properly mock the 'location provider' to test this, so the actual protocol and domains are the jsdom's default: http: and localhost. Should I add a functional test to test the behavior in a real browser environ?
There was a problem hiding this comment.
it seems that jsdom doesn't provide an easy way to mock it. I'd rather skip it then, since The behavior is specified, this is not relying on internal browser implementation
…-for-app-absolute
mshustov
approved these changes
Feb 12, 2020
…-for-app-absolute
…-for-app-absolute
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Feb 13, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 13, 2020
* master: add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929)
pgayvallet
added a commit
that referenced
this pull request
Feb 13, 2020
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 13, 2020
* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #56868
Adds an
absoluteoption togetUrlForAppto generate an absolute url instead of a 'relative' oneChecklist
Delete any items that are not applicable to this PR.
For maintainers