Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI][7.5] Fix space issue with TSVB requests from Metrics UI #57382

Closed
wants to merge 2 commits into from

Conversation

simianhacker
Copy link
Member

Summary

This PR fixes an issue with TSVB requests originating from the Metrics UI. The Metrics UI tries to recreate the request to TSVB based on the incoming request. When the request object is instantiated the wrong Base Path is used due to how the base path is injected. This PR overrides getBasePath() on the request object to return the original base path. This will allow the space to be honored.

Testing

  1. Create a new space that only displays the Metrics UI
  2. Create a role that has read access to metricbeat-* index pattern. Also add the previously created space to this role and limit the read access to Metrics
  3. Create a new user with the role you just created.
  4. Start indexing Metricbeat data for you local machine
  5. Visit the Metrics UI
  6. View Metrics for your host.
  7. You should see data in the charts.

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.2 labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary
Copy link
Contributor

Zacqary commented Apr 16, 2020

@simianhacker Looks like this never got merged, what's the status here?

@simianhacker
Copy link
Member Author

This is never going in :D

@simianhacker simianhacker deleted the tsvb-space-issue branch April 17, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants