[ML] New Platform server shim: update filters routes to use new platform router #57597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
| { | ||
| path: '/api/ml/filters', | ||
| validate: { | ||
| body: schema.object({ ...createFilterSchema }), |
There was a problem hiding this comment.
We don't actually need to create the new object here with the spread operator - it can just be passed in plainly like schema.object(createFilterSchema).
I did it this way by mistake the first time and will clean those up. It still works but is just unnecessary.
There was a problem hiding this comment.
Done in 8cd2ec8
| path: '/api/ml/filters/{filterId}', | ||
| validate: { | ||
| params: schema.object({ filterId: schema.string() }), | ||
| body: schema.object({ ...updateFilterSchema }), |
There was a problem hiding this comment.
Done in 8cd2ec8
alvarezmelissa87
approved these changes
Feb 13, 2020
peteharverson
force-pushed
the
ml-filters-np-routes
branch
from
23d344b
to
02dc48f
Compare
darnautov
approved these changes
Feb 14, 2020
x-pack/legacy/plugins/ml/server/models/filter/filter_manager.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
78 tasks
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
pushed a commit
that referenced
this pull request
Feb 14, 2020
…orm router (#57597) (#57717) * [ML] Update filters routes to use new platform router * [ML] Edits to filters route following review * [ML] Edits following review and fix job service api docs Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates all filters routes to use new platform router.
Related meta issue: #49743
Checklist