[Maps] Add XYZTMSSource unit test #58567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
changed the title
thomasneirynck
added
chore
release_note:skip
thomasneirynck
commented
Feb 26, 2020
| @@ -4,11 +4,17 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { IFieldType } from '../../../../../src/plugins/data/common/index_patterns/fields'; | |||
There was a problem hiding this comment.
this import was an oversight. remove.
thomasneirynck
commented
Feb 26, 2020
| it('should create a tile-layer', () => { | ||
| const source = new XYZTMSSource(descriptor, null); | ||
| const layer: ILayer = source.createDefaultLayer(); | ||
| expect(layer instanceof TileLayer).toEqual(true); |
There was a problem hiding this comment.
this is more to illustrate the typing in this PR. When TileLayer will be used in signatures in other .ts files (not yet the case), the actual type-checking will also be enforced by the compiler.
thomasneirynck
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
16 tasks
nreese
reviewed
Feb 26, 2020
nreese
reviewed
Feb 26, 2020
x-pack/legacy/plugins/maps/public/layers/sources/xyz_tms_source.test.ts
Outdated
Show resolved
Hide resolved
nreese
reviewed
Feb 26, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
approved these changes
Feb 26, 2020
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Feb 26, 2020
thomasneirynck
added a commit
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests for the XYZTMSSource.
It also introduces the boilerplate for the type-declaration files of two core components in Maps.
ISourceILayerand some of their dependencies.
This will also help condense the #57879 PR, as that one will extend the object model.