Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License checks for actions plugin #59070

Merged
merged 22 commits into from
Mar 20, 2020
Merged

License checks for actions plugin #59070

merged 22 commits into from
Mar 20, 2020

Commits on Mar 2, 2020

  1. Define minimum license required for each action type (#58668)

    * Add minimum required license
    
    * Require at least gold license as a minimum license required on third party action types
    
    * Use strings for license references
    
    * Ensure license type is valid
    
    * Fix some tests
    
    * Add servicenow to gold
    
    * Add tests
    
    * Set license requirements on other built in action types
    
    * Use jest.Mocked<ActionType> instead
    
    * Change servicenow to platinum
    
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
    mikecote and elasticmachine committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    a28e6db View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    4ba2fe4 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Configuration menu
    Copy the full SHA
    52c06ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cae5286 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'actions/license-checks' of github.com:elastic/kibana in…

    …to actions/license-checks
    mikecote committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    0a50516 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Configuration menu
    Copy the full SHA
    708789c View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    efba040 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a0d12c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9181f5a View commit details
    Browse the repository at this point in the history
  4. Add license checks to action HTTP APIs (#59153)

    * Initial work
    
    * Handle errors in update action API
    
    * Add unit tests for APIs
    
    * Make action executor throw when action type isn't enabled
    
    * Add test suite for basic license
    
    * Fix ESLint errors
    
    * Fix failing tests
    
    * Attempt 1 to fix CI
    
    * ESLint fixes
    
    * Create sendResponse function on ActionTypeDisabledError
    
    * Make disabled action types by config return 403
    
    * Remove switch case
    
    * Fix ESLint
    mikecote committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    6b7a134 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Add license checks within alerting / actions framework (#59699)

    * Initial work
    
    * Handle errors in update action API
    
    * Add unit tests for APIs
    
    * Verify action type before scheduling action task
    
    * Make actions plugin.execute throw error if action type is disabled
    
    * Bug fixes
    
    * Make action executor throw when action type isn't enabled
    
    * Add test suite for basic license
    
    * Fix ESLint errors
    
    * Stop action task from re-running when license check fails
    
    * Fix failing tests
    
    * Attempt 1 to fix CI
    
    * ESLint fixes
    
    * Create sendResponse function on ActionTypeDisabledError
    
    * Make disabled action types by config return 403
    
    * Remove switch case
    
    * Fix ESLint
    
    * Fix confusing assertion
    
    * Add comment explaining double mock
    
    * Log warning when alert action isn't scheduled
    mikecote committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    9c5952e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    014e144 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. Merge with master

    mikecote committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8aa253e View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Configuration menu
    Copy the full SHA
    c04f180 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Merge with master

    mikecote committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    dfaae1d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    34fa1af View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Configuration menu
    Copy the full SHA
    12dfb25 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2020

  1. Disable action types in UI when license doesn't support it (#59819)

    * Initial work
    
    * Handle errors in update action API
    
    * Add unit tests for APIs
    
    * Verify action type before scheduling action task
    
    * Make actions plugin.execute throw error if action type is disabled
    
    * Bug fixes
    
    * Make action executor throw when action type isn't enabled
    
    * Add test suite for basic license
    
    * Fix ESLint errors
    
    * Stop action task from re-running when license check fails
    
    * Fix failing tests
    
    * Attempt 1 to fix CI
    
    * ESLint fixes
    
    * Return enabledInConfig and enabledInLicense from actions get types API
    
    * Disable cards that have invalid license in create connector flyout
    
    * Create sendResponse function on ActionTypeDisabledError
    
    * Make disabled action types by config return 403
    
    * Remove switch case
    
    * Fix ESLint
    
    * Disable when creating alert action
    
    * Return minimumLicenseRequired in /types API
    
    * Disable row in connectors when action type is disabled
    
    * Fix failing jest test
    
    * Some refactoring
    
    * Card in edit alert flyout
    
    * Sort action types by name
    
    * Add tooltips to create connector action type selector
    
    * Add tooltips to alert flyout action type selector
    
    * Add get more actions link in alert flyout
    
    * Add callout when creating a connector
    
    * Typos
    
    * remove float right and use flexgroup
    
    * replace pixels with eui variables
    
    * turn on sass lint for triggers_actions_ui dir
    
    * trying to add padding around cards
    
    * Add callout in edit alert screen when some actions are disabled
    
    * improve card selection for Add Connector flyout
    
    * Fix cards for create connector
    
    * Add tests
    
    * ESLint issue
    
    * Cleanup
    
    * Cleanup pt2
    
    * Fix type check errors
    
    * moving to 3-columns cards for connector selection
    
    * Change re-enable to enable terminology
    
    * Revert "Change re-enable to enable terminology"
    
    This reverts commit b497dfd.
    
    * Add re-enable comment
    
    * Remove unecessary fragment
    
    * Add type to actionTypeNodes
    
    * Fix EuiLink to not have opacity of 0.7 when not hovered
    
    * design cleanup in progress
    
    * updating classNames
    
    * using EuiIconTip
    
    * Remove label on icon tip
    
    * Fix failing jest test
    
    Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
    mikecote and andreadelrio committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    b54837c View commit details
    Browse the repository at this point in the history
  2. Merge with master

    mikecote committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    06a73ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0cbeaf0 View commit details
    Browse the repository at this point in the history
  4. PR feedback

    mikecote committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    375131e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3f1282 View commit details
    Browse the repository at this point in the history