Gracefully handle preflight errors #5908
Conversation
In the event of an error response from the preflight request, we now use the dropdown fatal error handler rather than the fullscreen unexpected error handler. This more closely emulates the behavior of an error on the actual search request.
|
It didn't work for me (as shown on zoom). I tried on Firefox and Chrome on my Windows 10. |
|
@LeeDr I cannot reproduce the issue you're having. I've tried accessing this from windows 7 on IE11 and chrome as well as from chrome/firefox/safari on os x, and I get intended behavior every time. I'm worried it may be an issue on windows 10, so I've asked @BigFunger to try to reproduce it. |
|
This worked for me on win10 with Firefox, IE, Chrome. Following the steps throws an index_not_found exception, full page on master, notification on pr. I was running in dev mode, so maybe this isn't taking into account any caching. |
|
@jbudz Since you've verified it, do you have any time to do a code review? |
|
Yep, this LGTM |
Gracefully handle preflight errors
|
Court Ewing merged this into the following branches!
|
In the event of an error response from the preflight request, we now use the dropdown fatal error handler rather than the fullscreen unexpected error handler. This more closely emulates the behavior of an error on the actual search request. Fixes #5908
In the event of an error response from the preflight request, we now use
the dropdown fatal error handler rather than the fullscreen unexpected
error handler. This more closely emulates the behavior of an error on
the actual search request.
The easiest way to test this is probably with shield. Remove the field_stats
permission from the kibana4 role and access the discover page of a
time-based index:
On master, you'll get a full page fatal error.
On this branch, you'll get a fatal error notice across the top of the page.
Fixes #5619