visualizations plugin np_ready #59149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
Feature:NP Migration
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Dosant
changed the title
|
@elasticmachine merge upstream |
Dosant
commented
Mar 3, 2020
| import { Vis, VisParams } from '../types'; | ||
| import { IAggConfig, isDateHistogramBucketAggConfig, setBounds } from '../../../../../data/public'; |
There was a problem hiding this comment.
setBounds is not static, but I decided to leave it as, because it is properly addressed by #58805
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
approved these changes
Mar 4, 2020
walterra
approved these changes
Mar 4, 2020
kibana-app-arch
automation
moved this from Review in progress
to Done in current release
Mar 4, 2020
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Mar 4, 2020
Dosant
added a commit
that referenced
this pull request
Mar 4, 2020
lukeelmers
moved this from Done in current release
to Done in previous release
in kibana-app-arch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #44121
Minor remaining clean-ups before cutting of
The only dependency for cut off is #42639
In this pr:
Remove
legacy_importsandlegacy_mocks:SavedSearchinterfaces. This is needed to make surevisualizationsare at least importing from np discover instead of legacy discover.SetBoundsis exception and will be resolved by Clean up date histogram agg type. #58805. UsecreateAggConfigfrom the contract and temporary import data plugin from legacy for this.defaultFeedbackMessageinto visualizationsChecklist
Delete any items that are not applicable to this PR.
For maintainers