Auto interval on date histogram is getting displayed as timestamp per… #59171

DianaDerevyankina · 2020-03-03T16:23:38Z

Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed

Summary

Incorrect interval displaying has been fixed by passing timeRange property from DefaultEditor through other components to DefaultEditorAgg. In DefaultEditorAgg this value is set to aggConfigs
timeRange when data changes in the editor.

Found out that because of setAggDescription hook the whole tree is rerendered, as some children are added dynamically.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

… 0 milliseconds when x-axis bucket is collapsed Closes elastic#57822

elasticmachine · 2020-03-03T16:23:41Z

Pinging @elastic/kibana-app (Team:KibanaApp)

timroes · 2020-03-03T22:29:45Z

I am sorry, we messed something up here. That issue that you referenced, should have been assigned to @ThomThomson but it seemed somehow we unassigned it again ~~(or was a fallout of the GitHub outages last week)~~. (the other PR has an explanation why it was unassigned again, sorry this was my mistake!)

So I'll be closing this in favor of the Devon's PR (which is currently going into the more correct direction): #59220

I am sorry for the inconvinience.

timroes · 2020-03-04T09:32:25Z

And according to our latest discussion reopening this again, and finishing this one.

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx

DianaDerevyankina · 2020-03-04T11:17:27Z

@timroes @sulemanof Could you review the changes, please?

DianaDerevyankina · 2020-03-04T11:24:58Z

@elasticmachine merge upstream

elasticmachine · 2020-03-04T11:25:00Z

merge conflict between base and head

src/legacy/core_plugins/vis_default_editor/public/components/controls/time_interval.tsx

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx

# Conflicts: # src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx # src/legacy/core_plugins/vis_default_editor/public/components/agg_group.tsx # src/legacy/core_plugins/vis_default_editor/public/components/sidebar/data_tab.tsx # src/legacy/core_plugins/vis_default_editor/public/components/sidebar/sidebar.tsx

dmlemeshko

I looked at functional tests and left a comment about using testSubjects service over find when possible

test/functional/apps/visualize/_area_chart.js

dmlemeshko

Functional tests changes LGTM

maryia-lapata

LGTM.
Tested locally on Chrome (Mac).

maryia-lapata · 2020-03-30T15:38:49Z

src/legacy/core_plugins/vis_default_editor/public/components/controls/time_interval.tsx

@@ -61,7 +61,7 @@ function validateInterval(
  timeBase?: string
 ) {
  if (definedOption) {
-    return { isValid: true };
+    return { isValid: true, interval: agg.buckets?.getInterval() };


Thanks for fixing scaled message when a user selects an option.

timroes · 2020-03-31T08:39:30Z

@elasticmachine merge upstream

timroes

Tested on Chrome Linux. Agg description when collapsed and warning for upscaling seem to work correctly now, no matter if time is switched via time picker or via brushing the chart. Code LGTM

sulemanof

LGTM, tested locally in Chrome in Area chart!
Thanks for adding FT for this, it will help to avoid regressions while refactoring in future!

kibanamachine · 2020-03-31T10:19:10Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: dd853aa
Flaky suites:
- kibana-ciGroup6

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/discover/_field_visualize·ts.discover app discover field visualize button should preserve app filters in visualize

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/61714

[00:00:00]       │
[00:01:45]         └-: discover app
[00:01:45]           └-> "before all" hook
[00:01:45]           └-> "before all" hook
[00:09:10]           └-: discover field visualize button
[00:09:10]             └-> "before all" hook
[00:09:10]             └-> "before all" hook
[00:09:10]               │ debg load kibana index with default index pattern
[00:09:10]               │ info [discover] Loading "mappings.json"
[00:09:10]               │ info [discover] Loading "data.json.gz"
[00:09:10]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:10]               │ info [discover] Created index ".kibana"
[00:09:10]               │ debg [discover] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:09:10]               │ info [discover] Indexed 2 docs into ".kibana"
[00:09:10]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana/llZpmXrETa6wDQwag946yQ] update_mapping [_doc]
[00:09:10]               │ debg Migrating saved objects
[00:09:10]               │ proc [kibana]   log   [09:08:33.452] [info][savedobjects-service] Creating index .kibana_2.
[00:09:10]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:10]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] updating number_of_replicas to [0] for indices [.kibana_2]
[00:09:10]               │ proc [kibana]   log   [09:08:33.521] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:09:10]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:09:10]               │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] updating number_of_replicas to [0] for indices [.kibana_1]
[00:09:10]               │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] 8082 finished with response BulkByScrollResponse[took=35.5ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:09:11]               │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana/llZpmXrETa6wDQwag946yQ] deleting index
[00:09:11]               │ proc [kibana]   log   [09:08:33.859] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:09:11]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_2/6ECDDECWQWCuw5uDwqqM8A] update_mapping [_doc]
[00:09:11]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_2/6ECDDECWQWCuw5uDwqqM8A] update_mapping [_doc]
[00:09:11]               │ proc [kibana]   log   [09:08:33.918] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:09:11]               │ proc [kibana]   log   [09:08:33.966] [info][savedobjects-service] Finished in 515ms.
[00:09:11]               │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:09:11]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_2/6ECDDECWQWCuw5uDwqqM8A] update_mapping [_doc]
[00:09:12]               │ info [logstash_functional] Loading "mappings.json"
[00:09:12]               │ info [logstash_functional] Loading "data.json.gz"
[00:09:12]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:09:12]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:09:12]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:09:14]               │ debg replacing kibana config doc: {"defaultIndex":"logstash-*"}
[00:09:14]               │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-debian-tests-xl-1585644022401631421] [.kibana_2/6ECDDECWQWCuw5uDwqqM8A] update_mapping [_doc]
[00:09:14]             └-> should visualize a field in area chart
[00:09:14]               └-> "before each" hook: global before each
[00:09:14]               └-> "before each" hook
[00:09:14]                 │ debg go to discover
[00:09:14]                 │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:14]                 │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:14]                 │ debg ... sleep(700) start
[00:09:14]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585645717541#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:14]                 │
[00:09:14]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:15]                 │ debg ... sleep(700) end
[00:09:15]                 │ debg returned from get, calling refresh
[00:09:16]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585645717541#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:16]                 │
[00:09:16]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:16]                 │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:16]                 │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:16]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:16]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:20]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:20]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:20]                 │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-03-31T09:08:41Z
[00:09:20]                 │        Adding connection to http://localhost:6161/elasticsearch
[00:09:20]                 │
[00:09:20]                 │      "
[00:09:20]                 │ debg ... sleep(501) start
[00:09:20]                 │ debg ... sleep(501) end
[00:09:20]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover
[00:09:20]                 │ debg TestSubjects.exists(statusPageContainer)
[00:09:20]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:23]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:23]                 │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:09:23]                 │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:09:23]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:09:23]                 │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:09:23]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:09:23]                 │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:09:23]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:23]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:24]                 │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:09:24]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:09:24]                 │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:09:24]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:24]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:24]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:24]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:24]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:24]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:24]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:24]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:24]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:24]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:09:24]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:24]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:24]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:24]                 │ debg ... sleep(500) start
[00:09:25]                 │ debg ... sleep(500) end
[00:09:25]                 │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:09:25]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:25]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:25]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:25]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:25]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:25]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:25]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:25]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:25]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:25]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:26]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:09:26]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:26]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:26]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:26]                 │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:09:26]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:09:29]                 │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:09:29]                 │ debg TestSubjects.click(querySubmitButton)
[00:09:29]                 │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:29]                 │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:29]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:30]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:30]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:31]               │ debg TestSubjects.click(field-phpmemory)
[00:09:31]               │ debg Find.clickByCssSelector('[data-test-subj="field-phpmemory"]') with timeout=10000
[00:09:31]               │ debg Find.findByCssSelector('[data-test-subj="field-phpmemory"]') with timeout=10000
[00:09:32]               │ debg visualize a phpmemory field
[00:09:32]               │ debg TestSubjects.click(fieldVisualize-phpmemory)
[00:09:32]               │ debg Find.clickByCssSelector('[data-test-subj="fieldVisualize-phpmemory"]') with timeout=10000
[00:09:32]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-phpmemory"]') with timeout=10000
[00:09:33]               │ debg isGlobalLoadingIndicatorVisible
[00:09:33]               │ debg TestSubjects.exists(globalLoadingIndicator)
[00:09:33]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:09:35]               │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:09:35]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:35]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:09:35]               │ debg Inspector.open
[00:09:35]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:35]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:38]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:38]               │ debg TestSubjects.click(openInspectorButton)
[00:09:38]               │ debg Find.clickByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[00:09:38]               │ debg Find.findByCssSelector('[data-test-subj="openInspectorButton"]') with timeout=10000
[00:09:38]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:38]               │ debg Inspector.expectTableData(0,10,58,320,2,171,080,2,3,240,1,3,520,1,3,880,1,4,120,1,4,640,1,4,760,1,5,680,1,7,160,1,7,400,1,8,400,1,8,800,1,8,960,1,9,400,1,10,280,1,10,840,1,13,080,1,13,360,1)
[00:09:38]               │ debg TestSubjects.find(inspectorPanel)
[00:09:38]               │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[00:09:38]               │ debg Close Inspector
[00:09:38]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:38]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:38]               │ debg Closing flyout inspectorPanel
[00:09:38]               │ debg TestSubjects.find(inspectorPanel)
[00:09:38]               │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[00:09:39]               │ debg Waiting up to 20000ms for flyout closed...
[00:09:39]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:39]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=1000
[00:09:40]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:40]               │ debg TestSubjects.exists(inspectorPanel)
[00:09:40]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:09:43]               │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:09:43]               └- ✓ pass  (12.4s) "discover app discover field visualize button should visualize a field in area chart"
[00:09:43]             └-> should preserve app filters in visualize
[00:09:43]               └-> "before each" hook: global before each
[00:09:43]               └-> "before each" hook
[00:09:43]                 │ debg go to discover
[00:09:43]                 │ debg navigating to discover url: http://localhost:6161/app/kibana#/discover
[00:09:43]                 │ debg Navigate to: http://localhost:6161/app/kibana#/discover
[00:09:43]                 │ debg ... sleep(700) start
[00:09:43]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585645746254#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:43]                 │
[00:09:43]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:44]                 │ debg ... sleep(700) end
[00:09:44]                 │ debg returned from get, calling refresh
[00:09:44]                 │ debg browser[INFO] http://localhost:6161/app/kibana?_t=1585645746254#/discover 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:09:44]                 │
[00:09:44]                 │ debg browser[INFO] http://localhost:6161/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:09:44]                 │ debg currentUrl = http://localhost:6161/app/kibana#/discover
[00:09:44]                 │          appUrl = http://localhost:6161/app/kibana#/discover
[00:09:44]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:44]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:09:47]                 │ debg TestSubjects.find(kibanaChrome)
[00:09:47]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:09:47]                 │ debg browser[INFO] http://localhost:6161/bundles/plugin/data/data.plugin.js 96:139630 "INFO: 2020-03-31T09:09:09Z
[00:09:47]                 │        Adding connection to http://localhost:6161/elasticsearch
[00:09:47]                 │
[00:09:47]                 │      "
[00:09:47]                 │ debg ... sleep(501) start
[00:09:48]                 │ debg ... sleep(501) end
[00:09:48]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:48]                 │ debg --- retry.try error: URL changed, waiting for it to settle
[00:09:48]                 │ debg ... sleep(501) start
[00:09:49]                 │ debg ... sleep(501) end
[00:09:49]                 │ debg in navigateTo url = http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(columns:!(_source),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:09:49]                 │ debg TestSubjects.exists(statusPageContainer)
[00:09:49]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:09:51]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:09:52]                 │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:09:52]                 │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:09:52]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:09:52]                 │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:09:52]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=2500
[00:09:52]                 │ debg TestSubjects.click(superDatePickerShowDatesButton)
[00:09:52]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=10000
[00:09:52]                 │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:09:52]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=2500
[00:09:52]                 │ debg TestSubjects.click(superDatePickerendDatePopoverButton)
[00:09:52]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerendDatePopoverButton"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:52]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:52]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:52]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:52]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:52]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 23, 2015 @ 18:31:44.000)
[00:09:52]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:52]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:52]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:53]                 │ debg ... sleep(500) start
[00:09:53]                 │ debg ... sleep(500) end
[00:09:53]                 │ debg TestSubjects.click(superDatePickerstartDatePopoverButton)
[00:09:53]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:53]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=10000
[00:09:53]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:54]                 │ debg Find.findByCssSelector('div.euiPopover__panel-isOpen') with timeout=10000
[00:09:54]                 │ debg TestSubjects.click(superDatePickerAbsoluteTab)
[00:09:54]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:54]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteTab"]') with timeout=10000
[00:09:54]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:54]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:54]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:54]                 │ debg TestSubjects.setValue(superDatePickerAbsoluteDateInput, Sep 19, 2015 @ 06:31:44.000)
[00:09:54]                 │ debg TestSubjects.click(superDatePickerAbsoluteDateInput)
[00:09:54]                 │ debg Find.clickByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:54]                 │ debg Find.findByCssSelector('[data-test-subj="superDatePickerAbsoluteDateInput"]') with timeout=10000
[00:09:54]                 │ debg TestSubjects.exists(superDatePickerApplyTimeButton)
[00:09:54]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerApplyTimeButton"]') with timeout=2500
[00:09:57]                 │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerApplyTimeButton"] is not displayed
[00:09:57]                 │ debg TestSubjects.click(querySubmitButton)
[00:09:57]                 │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:57]                 │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:09:58]                 │ debg Find.waitForElementStale with timeout=10000
[00:09:58]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:09:58]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:10:00]               │ debg TestSubjects.click(addFilter)
[00:10:00]               │ debg Find.clickByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:10:00]               │ debg Find.findByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:10:00]               │ debg comboBox.set, comboBoxSelector: filterFieldSuggestionList
[00:10:00]               │ debg TestSubjects.find(filterFieldSuggestionList)
[00:10:00]               │ debg Find.findByCssSelector('[data-test-subj="filterFieldSuggestionList"]') with timeout=10000
[00:10:00]               │ debg comboBox.setElement, value: bytes
[00:10:00]               │ debg comboBox.isOptionSelected, value: bytes
[00:10:03]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:03]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:03]               │ debg Find.allByCssSelector('.euiFilterSelectItem[title^="bytes"]') with timeout=2500
[00:10:03]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:03]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:06]               │ debg --- retry.tryForTime error: [data-test-subj~="comboBoxOptionsList"] is not displayed
[00:10:06]               │ debg comboBox.set, comboBoxSelector: filterOperatorList
[00:10:06]               │ debg TestSubjects.find(filterOperatorList)
[00:10:06]               │ debg Find.findByCssSelector('[data-test-subj="filterOperatorList"]') with timeout=10000
[00:10:06]               │ debg comboBox.setElement, value: is between
[00:10:06]               │ debg comboBox.isOptionSelected, value: is between
[00:10:09]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:09]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:09]               │ debg Find.allByCssSelector('.euiFilterSelectItem[title^="is between"]') with timeout=2500
[00:10:09]               │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:10:09]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:10:12]               │ debg --- retry.tryForTime error: [data-test-subj~="comboBoxOptionsList"] is not displayed
[00:10:12]               │ debg TestSubjects.find(filterParams)
[00:10:12]               │ debg Find.findByCssSelector('[data-test-subj="filterParams"]') with timeout=10000
[00:10:22]               │ debg TestSubjects.click(saveFilter)
[00:10:22]               │ debg Find.clickByCssSelector('[data-test-subj="saveFilter"]') with timeout=10000
[00:10:22]               │ debg Find.findByCssSelector('[data-test-subj="saveFilter"]') with timeout=10000
[00:10:23]               │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:10:23]               │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:10:23]               │ debg TestSubjects.click(field-geo.src)
[00:10:23]               │ debg Find.clickByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:10:23]               │ debg Find.findByCssSelector('[data-test-subj="field-geo.src"]') with timeout=10000
[00:10:23]               │ debg visualize a geo.src field with filter applied
[00:10:23]               │ debg TestSubjects.click(fieldVisualize-geo.src)
[00:10:23]               │ debg Find.clickByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:23]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:33]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:33]               │      Wait timed out after 10090ms
[00:10:34]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:44]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:44]               │      Wait timed out after 10053ms
[00:10:44]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:10:54]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:10:54]               │      Wait timed out after 10052ms
[00:10:55]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:05]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:05]               │      Wait timed out after 10017ms
[00:11:06]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:16]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:16]               │      Wait timed out after 10029ms
[00:11:16]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:26]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:26]               │      Wait timed out after 10036ms
[00:11:27]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:37]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:37]               │      Wait timed out after 10007ms
[00:11:37]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:47]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:47]               │      Wait timed out after 10027ms
[00:11:48]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:11:58]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:11:58]               │      Wait timed out after 10006ms
[00:11:58]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:08]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:08]               │      Wait timed out after 10050ms
[00:12:09]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:19]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:19]               │      Wait timed out after 10045ms
[00:12:19]               │ debg Find.findByCssSelector('[data-test-subj="fieldVisualize-geo.src"]') with timeout=10000
[00:12:29]               │ debg --- retry.try error: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:29]               │      Wait timed out after 10039ms
[00:12:30]               │ debg --- retry.try error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
[00:12:30]               │      Wait timed out after 10039ms
[00:12:30]               │          at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
[00:12:30]               │          at process._tickCallback (internal/process/next_tick.js:68:7)
[00:12:30]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/discover app discover field visualize button should preserve app filters in visualize.png"
[00:12:30]               │ info Current URL is: http://localhost:6161/app/kibana#/discover?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-19T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(_source),filters:!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,index:%27logstash-*%27,key:bytes,negate:!f,params:(gte:3500,lt:4000),type:range),range:(bytes:(gte:3500,lt:4000)))),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!())
[00:12:31]               │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/discover app discover field visualize button should preserve app filters in visualize.html
[00:12:31]               └- ✖ fail: "discover app discover field visualize button should preserve app filters in visualize"
[00:12:31]               │

Stack Trace

Error: retry.try timeout: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="fieldVisualize-geo.src"])
Wait timed out after 10039ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:841:17
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

History

💚 Build #37102 succeeded 8006513
💚 Build #34715 succeeded 1e9bb18
💚 Build #34445 succeeded 9ef6cac
💚 Build #33468 succeeded 6cd8a35
💚 Build #33376 succeeded c60a464

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#59171) * Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed Closes elastic#57822 * Fixed incorrect interval label displaying while scaling the chart. * Updated agg.test.tsx snapshot * Got rid of context and refactored agg hooks * Fixed agg.type.name check * Added functional tests to cover the date histogram interval editing * Fixed some expected values in tests * Updated some test cases * Added a new visualization to visualize archive * Added testSubjects service to replace find where possible * Updated tests to match updated behavior Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* upstream/master: (69 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...

#59171) (#61992) * Auto interval on date histogram is getting displayed as timestamp per 0 milliseconds when x-axis bucket is collapsed Closes #57822 * Fixed incorrect interval label displaying while scaling the chart. * Updated agg.test.tsx snapshot * Got rid of context and refactored agg hooks * Fixed agg.type.name check * Added functional tests to cover the date histogram interval editing * Fixed some expected values in tests * Updated some test cases * Added a new visualization to visualize archive * Added testSubjects service to replace find where possible * Updated tests to match updated behavior Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (64 commits) Adding PagerDuty icon to connectors cards (elastic#60805) Fix drag and drop flakiness (elastic#61993) Grok debugger migration (elastic#60658) Endpoint: Fix resolver SVG position issue (elastic#61886) [SIEM] version 7.7 rule import (elastic#61903) Added styles to make combobox list items wider for alerting flyout (elastic#61894) [UA] Tight worker loop can cause high CPU usage (elastic#60950) [ML] DF Analytics results table: use index pattern field format if one exists (elastic#61709) [ML] Catching unknown index pattern errors (elastic#61935) [Discover] Deangularize and euificate sidebar (elastic#47559) Endpoint: Add ts-node dev dependency (elastic#61884) Add an onBlur handler for the kuery bar. Only resubmit when input changes. (elastic#61901) [ML] Handle Empty Partition Field Values in Single Metric Viewer (elastic#61649) Auto interval on date histogram is getting displayed as timestamp per… (elastic#59171) [Maps] Explicitly pass fetch function to ems-client (elastic#61846) [SIEM][CASE] Fix aria-labels and translations (elastic#61670) [ML] Settings: Increase number of items that can be paged in calendars and filters lists (elastic#61842) [EPM] update epm filepath route (elastic#61910) APM] Set ignore_above to 1024 for telemetry saved object (elastic#61732) [Logs UI] Log stream row rendering (elastic#60773) ...

Auto interval on date histogram is getting displayed as timestamp per…

3831f21

… 0 milliseconds when x-axis bucket is collapsed Closes elastic#57822

DianaDerevyankina added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 3, 2020

DianaDerevyankina requested review from maryia-lapata and alexwizp March 3, 2020 16:23

DianaDerevyankina self-assigned this Mar 3, 2020

flash1293 mentioned this pull request Mar 3, 2020

Fix Time Range in Vis State #59220

Closed

7 tasks

timroes closed this Mar 3, 2020

timroes reopened this Mar 4, 2020

alexwizp reviewed Mar 4, 2020

View reviewed changes

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx Outdated Show resolved Hide resolved

Fixed incorrect interval label displaying while scaling the chart.

dc37142

Merge branch 'master' into 57822

a2a1c24

timroes suggested changes Mar 4, 2020

View reviewed changes

src/legacy/core_plugins/vis_default_editor/public/components/controls/time_interval.tsx Outdated Show resolved Hide resolved

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx Outdated Show resolved Hide resolved

timroes reviewed Mar 4, 2020

View reviewed changes

src/legacy/core_plugins/vis_default_editor/public/components/agg.tsx Outdated Show resolved Hide resolved

DianaDerevyankina added 3 commits March 4, 2020 16:43

Updated agg.test.tsx snapshot

8853881

Got rid of context and refactored agg hooks

85753cc

Fixed agg.type.name check

1c9ce07

DianaDerevyankina requested a review from timroes March 10, 2020 11:12

DianaDerevyankina added 4 commits March 12, 2020 14:34

Added functional tests to cover the date histogram interval editing

62251cd

Merge branch 'DziyanaDzeraviankina' into 57822

2c61ab9

Fixed some expected values in tests

c60a464

DianaDerevyankina added 3 commits March 16, 2020 18:45

Updated some test cases

6cd8a35

Merge branch 'DziyanaDzeraviankina' into 57822

76eb879

Added a new visualization to visualize archive

9ef6cac

maryia-lapata requested a review from dmlemeshko March 19, 2020 14:37

dmlemeshko reviewed Mar 19, 2020

View reviewed changes

test/functional/apps/visualize/_area_chart.js Outdated Show resolved Hide resolved

test/functional/apps/visualize/_area_chart.js Outdated Show resolved Hide resolved

test/functional/apps/visualize/_area_chart.js Outdated Show resolved Hide resolved

Added testSubjects service to replace find where possible

1e9bb18

DianaDerevyankina requested a review from dmlemeshko March 23, 2020 08:52

dmlemeshko approved these changes Mar 23, 2020

View reviewed changes

DianaDerevyankina marked this pull request as ready for review March 23, 2020 14:47

DianaDerevyankina added 2 commits March 30, 2020 12:36

Merge branch 'DziyanaDzeraviankina' into 57822

4924c3b

Updated tests to match updated behavior

8006513

maryia-lapata approved these changes Mar 30, 2020

View reviewed changes

maryia-lapata reviewed Mar 30, 2020

View reviewed changes

alexwizp approved these changes Mar 31, 2020

View reviewed changes

timroes added the v7.8.0 label Mar 31, 2020

Merge branch 'master' into 57822

dd853aa

timroes approved these changes Mar 31, 2020

View reviewed changes

sulemanof approved these changes Mar 31, 2020

View reviewed changes

timroes added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Mar 31, 2020

DianaDerevyankina merged commit f29a5dd into elastic:master Mar 31, 2020

DianaDerevyankina mentioned this pull request Mar 31, 2020

[7.x] Auto interval on date histogram is getting displayed as timestamp per… (#59171) #61992

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto interval on date histogram is getting displayed as timestamp per… #59171

Auto interval on date histogram is getting displayed as timestamp per… #59171

DianaDerevyankina commented Mar 3, 2020 •

edited

elasticmachine commented Mar 3, 2020

timroes commented Mar 3, 2020 •

edited

timroes commented Mar 4, 2020

DianaDerevyankina commented Mar 4, 2020

DianaDerevyankina commented Mar 4, 2020

elasticmachine commented Mar 4, 2020

dmlemeshko left a comment

dmlemeshko left a comment

maryia-lapata left a comment

maryia-lapata Mar 30, 2020

timroes commented Mar 31, 2020

timroes left a comment

sulemanof left a comment

kibanamachine commented Mar 31, 2020

Standard Out

Stack Trace

Auto interval on date histogram is getting displayed as timestamp per… #59171

Auto interval on date histogram is getting displayed as timestamp per… #59171

Conversation

DianaDerevyankina commented Mar 3, 2020 • edited

Summary

Checklist

For maintainers

elasticmachine commented Mar 3, 2020

timroes commented Mar 3, 2020 • edited

timroes commented Mar 4, 2020

DianaDerevyankina commented Mar 4, 2020

DianaDerevyankina commented Mar 4, 2020

elasticmachine commented Mar 4, 2020

dmlemeshko left a comment

Choose a reason for hiding this comment

dmlemeshko left a comment

Choose a reason for hiding this comment

maryia-lapata left a comment

Choose a reason for hiding this comment

maryia-lapata Mar 30, 2020

Choose a reason for hiding this comment

timroes commented Mar 31, 2020

timroes left a comment

Choose a reason for hiding this comment

sulemanof left a comment

Choose a reason for hiding this comment

kibanamachine commented Mar 31, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

DianaDerevyankina commented Mar 3, 2020 •

edited

timroes commented Mar 3, 2020 •

edited