[ML] Fixes to error handling for analytics jobs and file data viz #60249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
v8.0.0
Feature:File and Index Data Viz
peteharverson
requested review from
darnautov,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Mar 16, 2020
...n/data_frame_analytics/pages/analytics_management/components/analytics_list/expanded_row.tsx
Outdated
Show resolved
Hide resolved
| @@ -39,12 +39,25 @@ export interface CreateAnalyticsFormProps { | |||
| state: State; | |||
| } | |||
|
|
|||
| interface ErrorResponse { | |||
There was a problem hiding this comment.
question: do we have a generic interface for the error response?
There was a problem hiding this comment.
Added new ErrorResponse interface in d8926e2
...on/datavisualizer/file_based/components/file_datavisualizer_view/file_datavisualizer_view.js
Outdated
Show resolved
Hide resolved
jgowdyelastic
approved these changes
Mar 16, 2020
| items: Object.entries(stateValues).map(s => { | ||
| return { title: s[0].toString(), description: getItemDescription(s[1]) }; | ||
| items: Object.entries(stateValues).map(([stateKey, stateValue]) => { | ||
| if (stateKey.toString() === 'state') { |
There was a problem hiding this comment.
complete nit, stateKey.toString() is called 3 times in here. it could be pulled out into a title var at the top of the function.
There was a problem hiding this comment.
Done in d3df262
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes handling of errors in the creation of data frame analytics jobs, and the upload in the file data visualizer to provide more details to the user on the error that has occured.
Previously the message part of the error response received from the server was not getting displayed in the UI.
Example from before of permissions error in creation of analytics job:
And after:
and example of fix in file data visualizer upload error:
Also fixes display in the
EuiBadgetooltip of the failure reason in the data frame analytics job list (previously tooltip was not displaying the failure reason), and adds anEuiBadgefor the display of the job state to highlight errors in the expanded row:Checklist