Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Migrate dual validated range (#59689) #60312

Merged
merged 1 commit into from
Mar 16, 2020

Commits on Mar 16, 2020

  1. Migrate dual validated range (elastic#59689)

    * Move validated range files to new NP location
    
    * Update refs in code
    
    * Clean up old validated range files
    
    * Change relative paths to 'kibana-react'. Some clean up
    
    * Change to relative paths
    
    * Fix i18n errors
    
    * i18n clean up. Export module explicitly
    
    * Change files over to TS to prevent build issue where validated range was missing
    
    * Clean up TS conversion
    
    * More clean up. Extend EuiRangeProps
    
    * Remove unneeded ts-ignore
    
    * Review feedback and test fixes
    
    * Change double to single quotes
    
    * min and max aren't always passed, make optional
    
    * Type updates
    
    * Review feedback. Set state to empty on init and add ignore comment
    
    * Review feedback
    
    * Add back in last 2 ts-ignores. Build fails without focusable attribute on EuiDualRange & No good alternatives for spread syntax in TS components
    
    * Rollback change to state init. Initializing state to null actually triggers a react browser warning and complicates using 'prevState' in getDerivedStateFromProps
    
    Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
    Aaron Caldwell and elasticmachine committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    0f3dce9 View commit details
    Browse the repository at this point in the history