Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating project assigner workflows to v2.0.0 of the action and back to default tokens #60577

Merged
merged 19 commits into from Mar 19, 2020

Conversation

alexh97
Copy link
Contributor

@alexh97 alexh97 commented Mar 18, 2020

Summary

We converted the entirety of the project-assigner action to use the GitHub GraphQL API (eliminating the use of the REST APIs) and have done some extensive testing in the github-actions repo.

Based on that testing, we feel fairly confident that we can re-enable the workflow for pull requests using the default GitHub token.

@alexh97 alexh97 requested review from leathekd and a team March 18, 2020 22:44
@alexh97 alexh97 added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Mar 18, 2020
Copy link

@leathekd leathekd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley
Copy link
Contributor

Awesome!

@alexh97 alexh97 merged commit eaf3dea into elastic:master Mar 19, 2020
@alexh97 alexh97 mentioned this pull request Mar 19, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60577 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 20, 2020
@spalger spalger added the backport:skip This commit does not require backporting label Mar 20, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 20, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 20, 2020
* master:
  [ML] Use a new ML endpoint to estimate a model memory (elastic#60376)
  [Logs UI] Correctly update the expanded log rate table rows (elastic#60306)
  fixes drag and drop flakiness (elastic#60625)
  Removing isEmptyState from embeddable input (elastic#60511)
  [Cross Cluster Replication] NP Shim (elastic#60121)
  Clear changes when canceling an edit to an alert (elastic#60518)
  Update workflow syntax (elastic#60626)
  Updating project assigner workflows to v2.0.0 of the action and back to default tokens (elastic#60577)
  migrate saved objects management edition view to react/typescript/eui (elastic#59490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants