[Maps] fix point to point source regression

[nreese]

Fixes regression caused by #57879.

#57879 changed AbstractESSource._getGeoField from a method function to an arrow function. By making the function an arrow function, it moved the function from prototype to the instance. This means that even though ESPewPewSource overrides the method on the prototype, AbstractESSource will use the version on the instance instead of looking at the protoype change.

Here is the error in action

Now pew-pew works as expected

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[thomasneirynck]

code review

[nreese]

If you are wondering why there was no functional test to catch this regression, point to point source was added when percy visual testing was all the rage. So the functional testing for this is using percy and those tests have been disabled and no longer fail builds.

I have added a functional test to ensure that pew-pew source works even if percy tests are disabled.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f749d89

History

• 💚 Build #35478 succeeded aae9b4a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream