Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM][Detections Engine] - Add rule markdown to timeline global notes #61026

Merged
merged 16 commits into from
Mar 30, 2020

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Mar 24, 2020

Summary

This is part of #59176 - broke up into smaller PRs.
Frontend PR - #60108
Backend PR - #59796

This PR adds functionality for rules investigation guide markdown field - referred to here as "rule note" (not to be confused with timeline notes). When opening a signal in timeline, if a "rule note" exists, it will create a new global timeline note with the guide content as the first note. Similar to how the other rule fields function, if "rule note" is updated, the new content will apply to new signals generated from that new rule version, timeline notes created from earlier rule versions are not updated with the new "rule note".

To test, ensure you have a rule activated that includes a note. Go to Detections -> Manage signal detection rule -> select the rule that includes note -> under Detected Signals, click on timeline icon (Investigate in timeline). You should see the timeline open (with either the specified timeline template or default timeline template) and see a Note count of 1 that includes the rule note content.

  • Duplicating a timeline - the new timeline should not include any notes
  • Creating a timeline
    - if a rule guide exists, you should see 1 note in the new timeline that includes the guide content
    - if a rule guide does not exist, you should see 0 notes in new timeline

(https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
rule_mkdn_timeline_note

Per design, updated hover text from 'View in timeline' to 'Investigate in timeline':
Screen Shot 2020-03-25 at 11 28 57 PM

Per design, updated 'Investigation notes' to 'Investigation guide':
Screen Shot 2020-03-25 at 11 29 59 PM
Screen Shot 2020-03-25 at 11 29 21 PM

Checklist

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@yctercero yctercero self-assigned this Mar 26, 2020
@yctercero yctercero marked this pull request as ready for review March 26, 2020 11:51
@yctercero yctercero requested a review from a team as a code owner March 26, 2020 11:51
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit dd77dea into elastic:master Mar 30, 2020
yctercero added a commit to yctercero/kibana that referenced this pull request Mar 30, 2020
elastic#61026)

[SIEM][Detections Engine] - Add rule markdown to timeline global notes

* added functionality of new global timeline note created on init timeline creation if signal.rule.note exists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
yctercero added a commit to yctercero/kibana that referenced this pull request Mar 30, 2020
elastic#61026)

[SIEM][Detections Engine] - Add rule markdown to timeline global notes

* added functionality of new global timeline note created on init timeline creation if signal.rule.note exists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
yctercero added a commit that referenced this pull request Mar 30, 2020
#61026) (#61791)

* added functionality of new global timeline note created on init timeline creation if signal.rule.note exists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
yctercero added a commit that referenced this pull request Mar 30, 2020
#61026) (#61790)

* added functionality of new global timeline note created on init timeline creation if signal.rule.note exists

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@yctercero yctercero deleted the rule_mkd_timeline_note branch July 20, 2020 01:45
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants