[SIEM] Check auth status for privileges via security plugin #61334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Accounts for security being disabled, adds tests * Updates other auth-aware endpoints (import timeline, graphql) to account for security being disabled.
rylnd
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
patrykkopycinski
approved these changes
Mar 25, 2020
spong
approved these changes
Mar 25, 2020
There was a problem hiding this comment.
Checked out locally, ran with security disabled (via xpack.security.enabled: false), and was able to verify is_authenticated: false in the privileges API response (and the opposite as well for when security is enabled). LGTM! Thanks for the tests + cleanup here @rylnd 👍
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Mar 26, 2020
…stic#61334) * Accounts for security being disabled, adds tests * Updates other auth-aware endpoints (import timeline, graphql) to account for security being disabled.
rylnd
added a commit
that referenced
this pull request
Mar 26, 2020
) (#61383) * Accounts for security being disabled, adds tests * Updates other auth-aware endpoints (import timeline, graphql) to account for security being disabled.
rylnd
added a commit
that referenced
this pull request
Mar 26, 2020
) (#61384) * Accounts for security being disabled, adds tests * Updates other auth-aware endpoints (import timeline, graphql) to account for security being disabled. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #59225
account for security being disabled.
Checklist
Delete any items that are not applicable to this PR.
For maintainers