Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert threshold line disappears #61499

Merged
merged 1 commit into from Mar 27, 2020
Merged

Fix alert threshold line disappears #61499

merged 1 commit into from Mar 27, 2020

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Mar 26, 2020 •
edited

Summary

fix #60955 upgrading @elastic/charts from 18.1.0 to 18.1.1

@elastic/charts update followed procedure: elastic/elastic-charts#583

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience release_note:fix Feature:Alerting v8.0.0 v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Mar 26, 2020
@markov00 markov00 requested a review from a team as a code owner March 26, 2020 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@markov00 markov00 requested a review from gmmorris March 26, 2020 17:10
@markov00 markov00 changed the title fix(line_annotation): keep the spec in state after chart rerender Fix alert threshold line disappears Mar 26, 2020
spalger
spalger approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operations LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gmmorris
Copy link
Contributor

LGTM :)
Thanks

@markov00 markov00 merged commit ba3d639 into elastic:master Mar 27, 2020
@markov00 markov00 mentioned this pull request Mar 27, 2020
Merged
markov00 added a commit to markov00/kibana that referenced this pull request Mar 27, 2020
@markov00
fix(line_annotation): keep the spec in state after chart rerender (el…
49888fe 
…astic#61499)
@markov00 markov00 mentioned this pull request Mar 27, 2020
Merged
markov00 added a commit to markov00/kibana that referenced this pull request Mar 27, 2020
@markov00
fix(line_annotation): keep the spec in state after chart rerender (el…
bc1214f 
…astic#61499)
markov00 added a commit that referenced this pull request Mar 27, 2020
@markov00
fix(line_annotation): keep the spec in state after chart rerender (#6…
25a7687 
…1499) (#61598)
markov00 added a commit that referenced this pull request Mar 27, 2020
@markov00
fix(line_annotation): keep the spec in state after chart rerender (#6…
1d6552c 
…1499) (#61600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmorris gmmorris gmmorris approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threshold line disappears
5 participants
@markov00 @elasticmachine @kibanamachine @gmmorris @spalger