Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 12 #61587

Merged
merged 33 commits into from
Nov 12, 2020
Merged

Upgrade Node.js to version 12 #61587

merged 33 commits into from
Nov 12, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Mar 27, 2020

Depends on #80468

This upgrades the Node.js runtime to a new major version.

For a complete list of changes in the Node.js runtime, see the Node.js CHANGELOG. For only the breaking changes, see the list of notable changes for v11 and v12 respectively.

Closes #47968
Closes #26379

Major changes to Node.js impacting this upgrade

Release note

Upgrades the major Node.js version used by and shipped with Kibana from v10 to v12. This includes support for TLSv1.3 and three new cipher suites: TLS_AES_256_GCM_SHA384, TLS_CHACHA20_POLY1305_SHA256, and TLS_AES_128_GCM_SHA256.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@watson watson force-pushed the bump-node branch 3 times, most recently from 6880749 to 7b18da9 Compare April 2, 2020 14:34
src/core/public/http/types.ts Show resolved Hide resolved
@watson watson force-pushed the bump-node branch 2 times, most recently from a8698ea to 9b80d5b Compare April 6, 2020 17:14
@watson watson marked this pull request as ready for review April 6, 2020 19:58
@watson watson requested review from a team as code owners April 6, 2020 19:58
@watson watson requested a review from a team April 6, 2020 19:58
@watson watson added v6.8.9 and removed v6.8.8 labels Apr 6, 2020
@watson watson requested a review from a team November 12, 2020 06:16
@watson watson requested review from a team and removed request for oatkiller, cjcenizal and a team November 12, 2020 06:48
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n changes look good. only a trival snapshot update.

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana Presentation changes LGTM! Thanks for explaining the Promise / ticks change that happened in Node 11.

@watson watson requested a review from a team November 12, 2020 20:52
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest Management change LGTM

@watson watson merged commit 4c49d5d into elastic:master Nov 12, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 12, 2020

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 696.3KB 696.2KB -24.0B
monitoring 966.0KB 966.0KB +6.0B
securitySolution 7.9MB 7.9MB +16.0B
total -2.0B

Distributable file count

id before after diff
default 42810 42857 +47
oss 22464 22511 +47

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaUtils 150.2KB 150.4KB +128.0B
spaces 290.4KB 290.4KB +80.0B
upgradeAssistant 74.5KB 74.5KB -24.0B
total +184.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson
Copy link
Contributor Author

watson commented Nov 12, 2020

FYI: This PR was merged before CI was passing on purpose, knowing that there would be an issue with the TypeScript tests. This is being fixed in master.

@watson watson deleted the bump-node branch November 13, 2020 08:23
watson added a commit that referenced this pull request Nov 13, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 16, 2020
* master:
  [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462)
  [Enterprise Search] Share Loading component (elastic#83246)
  Consolidates Jest configuration files and scripts (elastic#82671)
  APM header changes (elastic#82870)
  [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727)
  [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889)
  [packerCache] fix gulp usage, don't archive node_modules (elastic#83327)
  Upgrade Node.js to version 12 (elastic#61587)
  [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734)
  [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011)
  [DOCS] Updates Discover docs (elastic#82773)
  [ML] Data frame analytics: Adds map view (elastic#81666)
  enables actions scoped within the stack to register at Basic license (elastic#82931)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dependencies release_note:enhancement Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Node 12.x Add TLS 1.3 Support