[ML] Do not init model memory estimation with the default value #61589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
|
Verifying test stability in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/308/ ... |
| : of(DEFAULT_MODEL_MEMORY_LIMIT); | ||
| tap(v => { | ||
| // eslint-disable-next-line no-console | ||
| console.log('New config: ', JSON.stringify(v, null, 2)); |
There was a problem hiding this comment.
these log messages are adding a lot of information to the console. are they still needed?
There was a problem hiding this comment.
I still need them for checking the flaky test runner, will remove after
|
retest |
1 similar comment
|
retest |
peteharverson
approved these changes
Apr 2, 2020
|
It works fine on my local machine. In order to check that this PR doesn't introduce test flakiness, we're validating it in 40 runs here: |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
ML tests passed 40 times in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/332/, so it seems no test flakiness has been introduced ✔️ |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Apr 3, 2020
…tic#61589) * [ML] do not init model memory estimator with the default value * [ML] enhance model_memory_estimator logic, update unit tests * [ML] don't call the endpoint when start the job cloning * [ML] unit tests * [ML] use skip * [ML] remove unused parameter * [ML] try to disable 'disable-dev-shm-usage' * [ML] revert webdriver.ts, add debug logging * [ML] add debug logging * [ML] fix time range initialization * [ML] fix with useMemo * [ML] fix categorization validation check * [ML] remove wrong setIsWizardReady * [ML] revert page.tsx, update model_memory_estimator.ts and tests, skip failing tests * [ML] adjust unit test description * [ML] fix _runAdvancedValidation * [ML] support async validation init of categorization job creator * [ML] adjust unit tests
darnautov
added a commit
that referenced
this pull request
Apr 3, 2020
…) (#62430) * [ML] do not init model memory estimator with the default value * [ML] enhance model_memory_estimator logic, update unit tests * [ML] don't call the endpoint when start the job cloning * [ML] unit tests * [ML] use skip * [ML] remove unused parameter * [ML] try to disable 'disable-dev-shm-usage' * [ML] revert webdriver.ts, add debug logging * [ML] add debug logging * [ML] fix time range initialization * [ML] fix with useMemo * [ML] fix categorization validation check * [ML] remove wrong setIsWizardReady * [ML] revert page.tsx, update model_memory_estimator.ts and tests, skip failing tests * [ML] adjust unit test description * [ML] fix _runAdvancedValidation * [ML] support async validation init of categorization job creator * [ML] adjust unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #60888.
Prevent the model memory estimator to emit the default value on subscription start.
Checklist