-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests Endpoint App Host Detail #61857
Merged
charlie-pichette
merged 41 commits into
elastic:master
from
charlie-pichette:Tests_Host-Detail
Mar 31, 2020
Merged
Tests Endpoint App Host Detail #61857
charlie-pichette
merged 41 commits into
elastic:master
from
charlie-pichette:Tests_Host-Detail
Mar 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix location of es archive file
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
Pinging @elastic/endpoint-response (Team:Endpoint Response) |
nnamdifrankie
approved these changes
Mar 31, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
charlie-pichette
added a commit
that referenced
this pull request
Apr 2, 2020
* endpoint-161-refactor-management-list-test * fix location of es archive file * restored missing data and added new tests * remove commented out code * implement suggested enhancments * fix api tests to use the restored data * add endpoint metadata to the alert es_archive * restore the original alerts/api_feature archive * skipped failing endpoint alert tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported
Feature:Endpoint
Elastic Endpoint feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Endpoint Response
Endpoint Response Team
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restored deleted test data for the Endpoint app Host List page tests. Added additional tests for Host Detail Flyout.
Skipped failing endpoint alert tests.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11