Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Prevent "For the last" expression from jumping #62414

Merged
merged 2 commits into from
Apr 6, 2020
Merged

[APM] Prevent "For the last" expression from jumping #62414

merged 2 commits into from
Apr 6, 2020

Conversation

dgieselaar
Copy link
Member

Closes #61063.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 3, 2020
@dgieselaar dgieselaar requested a review from a team as a code owner April 3, 2020 09:58
cauemarcondes
cauemarcondes approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit ca1d77c into elastic:master Apr 6, 2020
@dgieselaar dgieselaar deleted the for-the-last-jumps branch April 6, 2020 09:42
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Apr 6, 2020
@dgieselaar @elasticmachine
[APM] Prevent "For the last" expression from jumping (elastic#62414)
75116e1 
Closes elastic#61063.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dgieselaar dgieselaar mentioned this pull request Apr 6, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Apr 6, 2020
@dgieselaar @elasticmachine
[APM] Prevent "For the last" expression from jumping (elastic#62414)
237c034 
Closes elastic#61063.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@dgieselaar dgieselaar mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] "For the last" expression component jumps around when editing values
4 participants
@dgieselaar @kibanamachine @cauemarcondes @elasticmachine