[Reporting] Make usable default element positions #63191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
tsullivan
force-pushed
the
reporting/guard-screenshot-options
branch
from
765f170
to
1f8e959
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tsullivan
commented
Apr 15, 2020
| @@ -42,7 +45,7 @@ export function screenshotsObservableFactory( | |||
| mergeMap(() => openUrl(captureConfig, driver, url, conditionalHeaders, logger)), | |||
| mergeMap(() => getNumberOfItems(captureConfig, driver, layout, logger)), | |||
| mergeMap(async itemsCount => { | |||
| const viewport = layout.getViewport(itemsCount); | |||
| const viewport = layout.getViewport(itemsCount) || getDefaultViewPort(); | |||
There was a problem hiding this comment.
heads up @poffdeluxe, these changes might conflict in the branch you're working on regarding re-using the page object for multiple urls
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 16, 2020
* [Reporting] Make usable default element posistions * revert unrelated changes * fix ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 16, 2020
* [Reporting] Make usable default element posistions * revert unrelated changes * fix ts Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 17, 2020
* master: (56 commits) [i18n] Update CODEOWNERS (elastic#63354) add platform team definition of done (elastic#59993) [SIEM] move away from Joi for importing/exporting timeline (elastic#62125) Fix discover preserve url (elastic#63580) [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489) Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655) MIgrated index_header to react (elastic#63490) Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364) [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642) [Reporting] Make usable default element positions (elastic#63191) [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500) [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498) Split action types into own page (elastic#63516) [Lens] Only show copy on save for previously saved docs (elastic#63535) Update README.md (elastic#63622) Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554) Add uptime CODEOWNER entries. (elastic#63616) [ML] Extract apiDoc params from the schema definitions (elastic#62933) Fix alerting documentation encryption key requirement (elastic#63512) Fix CODEOWNERS and sass lint paths (elastic#63552) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #63192
Fixes the occasional error of
Error: Expected options.clip.width to not be 0, which causes a reporting job failure.Checklist
Delete any items that are not applicable to this PR.