[Maps] Convert AbstractSource and AbstractLayer to TS #63533

thomasneirynck · 2020-04-14T21:57:11Z

Converts source and layer to .ts modules.

This will greatly help navigation in IDEs, and make extending easier.

elasticmachine · 2020-04-14T21:57:14Z

Pinging @elastic/kibana-gis (Team:Geo)

…e_layer

nreese · 2020-04-15T19:57:10Z

x-pack/legacy/plugins/maps/public/selectors/map_selectors.js

    case HeatmapLayer.type:
      return new HeatmapLayer({ layerDescriptor, source });
    case BlendedVectorLayer.type:
-      return new BlendedVectorLayer({ layerDescriptor, source });
+      return new BlendedVectorLayer({ layerDescriptor, source, joins: [] });


Why does BlendedVectorLayer take joins? BlendedVectorLayer does not support joins so this seams like a strange thing to expose in the constructor.

consequence of requiring VectorLayerArguments as param. Can create new param-type

Or just make joins optional?

x-pack/plugins/maps/common/descriptor_types/style_property_descriptor_types.d.ts

x-pack/plugins/maps/public/layers/sources/es_geo_grid_source/es_geo_grid_source.d.ts

x-pack/plugins/maps/public/layers/sources/source.ts

x-pack/plugins/maps/public/layers/sources/source.js

x-pack/plugins/maps/public/layers/sources/source.ts

x-pack/plugins/maps/public/layers/styles/abstract_style.ts

x-pack/legacy/plugins/maps/public/selectors/map_selectors.js

x-pack/plugins/maps/common/descriptor_types/descriptor_types.d.ts

x-pack/plugins/maps/public/layers/sources/source.ts

kindsun · 2020-04-16T01:28:15Z

Thank you so much for doing all of this! Just left some minor comments

…e_layer

thomasneirynck · 2020-04-17T21:09:09Z

@elasticmachine merge upstream

thomasneirynck · 2020-04-20T13:23:06Z

@elasticmachine merge upstream

x-pack/plugins/maps/common/descriptor_types/descriptor_types.d.ts

nreese · 2020-04-20T13:14:52Z

x-pack/plugins/maps/public/layers/sources/es_source/es_source.d.ts

@@ -20,6 +20,7 @@ export interface IESSource extends IVectorSource {
    limit: number,
    initialSearchContext?: object
  ): Promise<SearchSource>;
+  loadStylePropsMeta(args: unknown): Promise<unknown>; // todo


args are

layerName: string, style: VectorStyle, dynamicStyleProps: IDynamicStyleProperty[], registerCancelCallback: (requestToken: symbol, callback: () => void): void, nextMeta: VectorSourceRequestMeta

return type is

RangeFieldMeta | CategoryFieldMeta

thanks for the signature. the return type is actually a raw ES response. Will leave typing of that for another PR, since it bloats scope.

…e_layer

nreese

lgtm
code review

nreese · 2020-04-20T15:27:29Z

x-pack/plugins/maps/public/layers/styles/abstract_style.ts

@@ -0,0 +1,60 @@
+/*


Should this file be renamed to style.ts since it contains IStyle

nreese · 2020-04-20T15:28:32Z

x-pack/plugins/maps/public/layers/styles/vector/vector_style.js

@@ -60,6 +60,7 @@ export class VectorStyle extends AbstractStyle {

  constructor(descriptor = {}, source, layer) {
    super();
+    descriptor = descriptor === null ? {} : descriptor;


Is this needed since function arguments defaults descriptor to {}

a null value doesn't fallback to the default

…e_layer

thomasneirynck · 2020-04-20T20:39:12Z

I'm unable to reproduce these functional test errors locally (https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/41853/).

? re-basing with master again ?

This reverts commit 0818769.

kibanamachine · 2020-04-22T04:31:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0151cd2

History

💔 Build #42294 failed 237d7ed
💔 Build #42002 failed 9db3ae8
💔 Build #41892 failed 28ffcc9
💔 Build #41853 failed eb9a691
💔 Build #41701 failed a9cbf10

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

initial commit

aa2243a

thomasneirynck added chore WIP Work in progress [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.8.0 labels Apr 14, 2020

thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label Apr 14, 2020

thomasneirynck added 8 commits April 14, 2020 18:19

fix more typing errors

331db51

more fixes

039da8b

fixes

e86a98b

compile issues

fea5eb2

tmp commit

1da66d6

Merge branch 'master' of github.com:elastic/kibana into maps/ts_sourc…

e0d6027

…e_layer

simplify typing

37668b6

cleanup sigs in selectors

39aafdc

thomasneirynck requested a review from a team as a code owner April 15, 2020 18:43

thomasneirynck requested review from nreese and kindsun April 15, 2020 18:43

thomasneirynck removed the WIP Work in progress label Apr 15, 2020

thomasneirynck mentioned this pull request Apr 15, 2020

[Maps] Add 3rd party vector tile support #62084

Merged

nreese reviewed Apr 15, 2020

View reviewed changes

feedback

ffa3364

kindsun reviewed Apr 16, 2020

View reviewed changes

x-pack/legacy/plugins/maps/public/selectors/map_selectors.js Outdated Show resolved Hide resolved

kindsun reviewed Apr 16, 2020

View reviewed changes

x-pack/legacy/plugins/maps/public/selectors/map_selectors.js Outdated Show resolved Hide resolved

kindsun reviewed Apr 16, 2020

View reviewed changes

x-pack/plugins/maps/common/descriptor_types/descriptor_types.d.ts Outdated Show resolved Hide resolved

kindsun reviewed Apr 16, 2020

View reviewed changes

x-pack/plugins/maps/public/layers/sources/source.ts Outdated Show resolved Hide resolved

thomasneirynck added 2 commits April 16, 2020 09:35

Merge branch 'master' of github.com:elastic/kibana into maps/ts_sourc…

46cb60f

…e_layer

feedback

a07bccc

thomasneirynck requested a review from kindsun April 16, 2020 14:33

thomasneirynck mentioned this pull request Apr 16, 2020

[Maps] fix term join agg key collision #63324

Merged

thomasneirynck added 5 commits April 16, 2020 15:47

Merge branch 'master' into maps/ts_source_layer

7e179a5

Merge branch 'master' of github.com:elastic/kibana into maps/ts_sourc…

674a440

…e_layer

fix faulty merge

5632680

fix tests

0a38ad1

fix typing

431c702

Merge branch 'master' into maps/ts_source_layer

a9cbf10

Merge branch 'master' into maps/ts_source_layer

eb9a691

nreese reviewed Apr 20, 2020

View reviewed changes

thomasneirynck requested a review from nreese April 20, 2020 13:52

thomasneirynck added 2 commits April 20, 2020 10:49

Feedback

0877b61

Merge branch 'master' of github.com:elastic/kibana into maps/ts_sourc…

28ffcc9

…e_layer

nreese approved these changes Apr 20, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into maps/ts_sourc…

9db3ae8

…e_layer

thomasneirynck added 7 commits April 21, 2020 10:29

Merge branch 'master' into maps/ts_source_layer

3e9decc

rename for consistency

908dca6

custom deep-equls

0818769

Revert "custom deep-equls"

8b49807

This reverts commit 0818769.

init tile-style

7d79866

allow null

237d7ed

fix test to reflect normalization

0151cd2

thomasneirynck merged commit 939bf2a into elastic:master Apr 22, 2020

thomasneirynck mentioned this pull request Apr 22, 2020

[7.x] [Maps] Convert AbstractSource and AbstractLayer to TS (#63533) #64182

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Apr 22, 2020

[Maps] Convert AbstractSource and AbstractLayer to TS (elastic#63533)

4a9ba8f

thomasneirynck added a commit that referenced this pull request Apr 22, 2020

[Maps] Convert AbstractSource and AbstractLayer to TS (#63533) (#64182)

23bc168

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Convert AbstractSource and AbstractLayer to TS #63533

[Maps] Convert AbstractSource and AbstractLayer to TS #63533

thomasneirynck commented Apr 14, 2020

elasticmachine commented Apr 14, 2020

nreese Apr 15, 2020

thomasneirynck Apr 15, 2020

nreese Apr 15, 2020

kindsun commented Apr 16, 2020

thomasneirynck commented Apr 17, 2020

thomasneirynck commented Apr 20, 2020

nreese Apr 20, 2020

thomasneirynck Apr 20, 2020

nreese left a comment

nreese Apr 20, 2020

nreese Apr 20, 2020

thomasneirynck Apr 21, 2020

thomasneirynck commented Apr 20, 2020

kibanamachine commented Apr 22, 2020

[Maps] Convert AbstractSource and AbstractLayer to TS #63533

[Maps] Convert AbstractSource and AbstractLayer to TS #63533

Conversation

thomasneirynck commented Apr 14, 2020

elasticmachine commented Apr 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kindsun commented Apr 16, 2020

thomasneirynck commented Apr 17, 2020

thomasneirynck commented Apr 20, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nreese left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thomasneirynck commented Apr 20, 2020

kibanamachine commented Apr 22, 2020

💚 Build Succeeded

History