Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed inability to clear numeric field in a "Group over top docs" condition #63543

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fixed inability to clear numeric field in a "Group over top docs" condition #63543

merged 1 commit into from
Apr 15, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #63224

@YulNaumenko YulNaumenko added bug Fixes for quality problems that affect the customer experience Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.7.1 labels Apr 14, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner April 14, 2020 23:36
@YulNaumenko YulNaumenko self-assigned this Apr 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris
gmmorris approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, worked as expected :)

@mikecote mikecote self-requested a review April 15, 2020 13:29
mikecote
mikecote approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YulNaumenko YulNaumenko merged commit 6f1fe67 into elastic:master Apr 15, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Apr 15, 2020
@YulNaumenko
Fixed inability to clear numeric field in a "Group over top docs" con…
8384977 
…dition (elastic#63543)
@YulNaumenko YulNaumenko mentioned this pull request Apr 15, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Apr 15, 2020
@YulNaumenko
Fixed inability to clear numeric field in a "Group over top docs" con…
f229962 
…dition (elastic#63543)
@YulNaumenko YulNaumenko mentioned this pull request Apr 15, 2020
Merged
YulNaumenko added a commit that referenced this pull request Apr 15, 2020
@YulNaumenko
Fixed inability to clear numeric field in a "Group over top docs" con…
ee078a5 
…dition (#63543) (#63589)
YulNaumenko added a commit that referenced this pull request Apr 15, 2020
@YulNaumenko
Fixed inability to clear numeric field in a "Group over top docs" con…
ba44fdb 
…dition (#63543) (#63588)
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
@YulNaumenko @wayneseymour
Fixed inability to clear numeric field in a "Group over top docs" con…
2795888 
…dition (#63543)
tsullivan pushed a commit to tsullivan/kibana that referenced this pull request Apr 15, 2020
@YulNaumenko @tsullivan
Fixed inability to clear numeric field in a "Group over top docs" con…
f55d915 
…dition (elastic#63543) (elastic#63588)
@mikecote mikecote added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmorris gmmorris gmmorris approved these changes

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inability to clear numeric field in a "Group over top docs" condition
5 participants
@YulNaumenko @elasticmachine @kibanamachine @gmmorris @mikecote