Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers to the sample curl #63548

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Conversation

radu-gheorghe
Copy link
Contributor

@radu-gheorghe radu-gheorghe commented Apr 15, 2020

Summary

At least in 7.x, the sample curl doesn't work without the kbn-xsrf and json headers.

For maintainers

At least in 7.x it doesn't work without the kbn-xsrf and json headers.
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@timroes timroes added Team:Docs Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Apr 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much for pushing this change!

@KOTungseth KOTungseth added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 16, 2020
@KOTungseth
Copy link
Contributor

@elasticmachine merge upstream

@KOTungseth
Copy link
Contributor

jenkins test this

@KOTungseth KOTungseth merged commit cf7da3c into elastic:master Apr 17, 2020
KOTungseth pushed a commit to KOTungseth/kibana that referenced this pull request Apr 17, 2020
* Add headers to the sample curl

At least in 7.x it doesn't work without the kbn-xsrf and json headers.

* More headers to curl commands

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
KOTungseth added a commit that referenced this pull request Apr 17, 2020
* Add headers to the sample curl

At least in 7.x it doesn't work without the kbn-xsrf and json headers.

* More headers to curl commands

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Radu Gheorghe <radu.gheorghe@sematext.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💝community release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Docs v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants