change createIndexPattern to do what it takes to make the indexPatternName*

[LeeDr]

Summary

I updated this PR so that we always pass the exact desired index pattern name in settings_page.createIndexPattern(). Within that method, there are 3 cases;

1. the "common case" where we pass in logstash-* and the method enters logstash- and we get the correct logstash-* because the UI appends a trailing *
2. the "non-wildcard case" which might be more typical when it isn't a time-based index. We pass in shakespeare and we get shakespeare (we remove the trailing * that the UI adds)
3. There appear to be a few cases where the UI does NOT append the trailing *.
   1. One of those is when the index pattern starts with * like a wildcarded cross cluster search index pattern *:makelogs-*.
   2. Another is the test case where the test enters ❤️. I thought the UI would append a * which would need to be removed, but it doesn't. So case Change of links to styles and js #2 above handles that by only removing the trailing char if the length of the index pattern in the field is greater than the length of the indexPatternName passed in.

A final check (which was already there) confirms that the final value matches what was passed in.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[LeeDr]

I have fixes for 2 failures in previous run;
Functional tests / Group 6 failure in Shakespeare test
X-Pack Chrome Functional tests / Group 1 failure in graph test

I don't have a fix for this one in X-Pack Chrome Functional tests / Group 2
(maybe just flaky?);

 1) event_log
       Event Log public API
         should support sorting by event end:
     retry.try timeout: Error: expected 'test 2020-04-28T22:00:22.722Z' to sort of equal 'test 2020-04-28T22:00:22.723Z'

[LeeDr]

There was one unrelated test failure. I'll run another pass.

[LeeDr]

@elasticmachine merge upstream

[dmlemeshko]

LGTM, I replied about possibility to use DELETE key.
Tested on MacOS 10.14.6 in both FF and Chrome

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b6cb054

History

• 💚 Build #44078 succeeded fbe9826
• 💔 Build #43893 failed 0907867
• 💔 Build #43743 failed db8acb4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[dmlemeshko]

LGTM. Tested locally.