Fix CCR search bug caused by paused follower indices #64717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r index name or remote cluster name when paused follower indices existed in the table.
cjcenizal
added
release_note:fix
Feature:CCR and Remote Clusters
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
cjcenizal
commented
Apr 28, 2020
| @@ -273,7 +273,7 @@ export class FollowerIndicesTable extends PureComponent { | |||
| }; | |||
|
|
|||
| const selection = { | |||
| onSelectionChange: selectedItems => this.setState({ selectedItems }), | |||
| onSelectionChange: newSelectedItems => this.setState({ selectedItems: newSelectedItems }), | |||
There was a problem hiding this comment.
I had to make this change to satisfy the linter.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
sebelga
approved these changes
May 4, 2020
cjcenizal
changed the title
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 4, 2020
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 4, 2020
# Conflicts: # x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 4, 2020
# Conflicts: # x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js
cjcenizal
added a commit
that referenced
this pull request
May 4, 2020
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
cjcenizal
added a commit
that referenced
this pull request
May 6, 2020
kibanamachine
removed
the
backport missing
cjcenizal
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note
Searching the follower indices table would crash Kibana whenever a follower index was paused. This is because the _ccr/stats API doesn't provide shard information for paused follower indices, but the search logic depended on this information being present. I've changed the logic to remove this dependency, so search behaves as expected.