Tag invalid objects instead of failing migrations #64885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
reviewed
May 1, 2020
Comment on lines
166
to
169
| valid: { | ||
| type: 'boolean', | ||
| }, | ||
| invalid_attributes: { | ||
| enabled: false, // Don't index invalid attributes | ||
| type: 'object', | ||
| }, |
There was a problem hiding this comment.
Should we nest all these new fields into a single nested field such as migration or status ? It may be a little cleaner?
There was a problem hiding this comment.
I've been thinking about this, it feels like something as important as the status: 'invalid' | 'corrupt' | 'valid' should be at the top-level rather than hidden under another layer.
7 tasks
|
I found the |
That does sound useful. I wonder how much work it really would be to define schema (with kbn/config-schema) for all SO types. |
You're thinking about automated schema generation from the mapping, or manual schema definition by the owners here? |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvbStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js.rollup app tsvb integration create rollup tsvbStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
I think a manual schema would be the most useful. I think adding definitions would be fairly straight-forward, the open question up until now was, what do we do when an object in the index is invalid. But it doesn't have to block on this PR, we could validate all incoming objects at the SavedObjectsRepository but exclude validation when reading from the index. |
|
From Section 5.5 in the "Improve saved object migrations RFC" #66056
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements step 1 from #55406
TODO:
{7.6.1: migrationTransformBuggyFn}->{7.6.2: migrationTransformFixedFn}Open questions:
migrate711->migrate730->migrate760. If there's a bug inmigrate711how do we release a fix so that invalid documents are automatically recovered in future versions?migrate711and then release a new no-op migration likemigrateNoop761. 👎 Causes a migration for all users even if they don't have invalid data.fixInvalid761that only matches migrationVersion of invalid documents. Unclear exactly how this would work. For now, set{migrationVersion: {['invalid:'+type]: ${currentKibanaVersion}}}Checklist
Delete any items that are not applicable to this PR.
For maintainers