Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logstash integration with monitoring #65165

Merged
merged 2 commits into from
May 6, 2020

Conversation

joshdover
Copy link
Contributor

Summary

The monitoringUiEnabled injected var was removed and broke the Logstash plugin's integration with Monitoring. This PR changes that check to simply look to see if the monitoring plugin is enabled at all.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Logstash Pipelines Logstash Pipeline UI related Team:Logstash release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration labels May 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover requested a review from mshustov May 4, 2020 19:54
@joshdover joshdover added this to Pending Review in kibana-core [DEPRECATED] via automation May 4, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@joshdover joshdover merged commit 5f31422 into elastic:master May 6, 2020
kibana-core [DEPRECATED] automation moved this from Pending Review to Done (7.8) May 6, 2020
@joshdover joshdover deleted the logstash/fix-monitoring branch May 6, 2020 16:42
joshdover added a commit to joshdover/kibana that referenced this pull request May 6, 2020
joshdover added a commit to joshdover/kibana that referenced this pull request May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logstash Pipelines Logstash Pipeline UI related Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Logstash v7.8.0
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants