-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logstash integration with monitoring #65165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
May 6, 2020
mshustov
approved these changes
May 6, 2020
@elasticmachine merge upstream |
user doesn't have permission to update head repository |
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
May 6, 2020
joshdover
added a commit
to joshdover/kibana
that referenced
this pull request
May 6, 2020
joshdover
added a commit
that referenced
this pull request
May 6, 2020
joshdover
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Logstash Pipelines
Logstash Pipeline UI related
Feature:NP Migration
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Team:Logstash
v7.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
monitoringUiEnabled
injected var was removed and broke the Logstash plugin's integration with Monitoring. This PR changes that check to simply look to see if themonitoring
plugin is enabled at all.Checklist
Delete any items that are not applicable to this PR.
For maintainers