Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Canvas location in nav #65519

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented May 6, 2020

Summary

Updates order of the nav (moving Canvas from first to third)

Closes #63429

@myasonik myasonik added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 REASSIGN from Team:Core UI Deprecated label for old Core UI team v7.8.0 v7.9.0 labels May 6, 2020
@myasonik myasonik requested a review from crob611 May 6, 2020 17:12
@myasonik myasonik requested a review from a team as a code owner May 6, 2020 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, being first was good while it lasted 🤷‍♂️

@myasonik
Copy link
Contributor Author

myasonik commented May 6, 2020

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik myasonik merged commit 402df7f into elastic:master May 6, 2020
@myasonik myasonik deleted the fix/canvas-order branch May 6, 2020 21:11
myasonik pushed a commit to myasonik/kibana that referenced this pull request May 6, 2020
myasonik pushed a commit to myasonik/kibana that referenced this pull request May 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 7, 2020
* master: (42 commits)
  fix SavedObjectMigrationMap type (elastic#65569)
  [Uptime] Improve cert flaky test (elastic#65458)
  [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532)
  [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508)
  [APM] Remove link from active page in the breadcrumb (elastic#65473)
  [SIEM] Fixes test flakiness (elastic#65510)
  [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471)
  Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780)
  move core provier to NP. allows to run tests on every page (elastic#64929)
  Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201)
  [functional tests] add some missing awaits (elastic#65566)
  Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539)
  [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307)
  Migrate Coordinate Maps to NP (elastic#64668)
  Updating Canvas location in nav (elastic#65519)
  [SIEM][Lists] Fixes up contracts to work outside of requests
  [Lens] Remove "inside only" option for treemap labels (elastic#65363)
  [Uptime] Add TLS alert functional test (elastic#65303)
  Fix z-index of kbnLoadingIndicator (elastic#65521)
  Fixed indice assertion to loop through expected keys (elastic#64684)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discuss] Move dashboard app as the first application in Kibana section
4 participants