Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event log] Fix flaky test #65658

Merged
merged 4 commits into from
May 7, 2020
Merged

[Event log] Fix flaky test #65658

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
172f85f
fixed same flaky problem in additional test
gmmorris May 7, 2020
1ff566d
Merge remote-tracking branch 'upstream/master' into event-log/fix-adi…
gmmorris May 7, 2020
2b2bc96
enabled tests
gmmorris May 7, 2020
b97343b
removed unused import
gmmorris May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions x-pack/test/plugin_api_integration/test_suites/event_log/public_api_integration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* you may not use this file except in compliance with the Elastic License.
*/

import { merge, omit, times, chunk, isEmpty } from 'lodash';
import { merge, omit, chunk, isEmpty } from 'lodash';
import uuid from 'uuid';
import expect from '@kbn/expect/expect.js';
import moment from 'moment';
Expand All @@ -19,9 +19,7 @@ export default function({ getService }: FtrProviderContext) {
const log = getService('log');
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/64723
// FLAKY: https://github.com/elastic/kibana/issues/64812
describe.skip('Event Log public API', () => {
describe('Event Log public API', () => {
it('should allow querying for events by Saved Object', async () => {
const id = uuid.v4();

Expand All @@ -45,11 +43,7 @@ export default function({ getService }: FtrProviderContext) {
it('should support pagination for events', async () => {
const id = uuid.v4();

const [firstExpectedEvent, ...expectedEvents] = times(6, () => fakeEvent(id));

// run one first to create the SO and avoid clashes
await logTestEvent(id, firstExpectedEvent);
await Promise.all(expectedEvents.map(event => logTestEvent(id, event)));
const expectedEvents = await logFakeEvents(id, 6);

await retry.try(async () => {
const {
Expand All @@ -59,10 +53,7 @@ export default function({ getService }: FtrProviderContext) {
expect(foundEvents.length).to.be(6);
});

const [expectedFirstPage, expectedSecondPage] = chunk(
[firstExpectedEvent, ...expectedEvents],
3
);
const [expectedFirstPage, expectedSecondPage] = chunk(expectedEvents, 3);

const {
body: { data: firstPage },
Expand Down