Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixes #6498 Remove mapping cache #6648

Closed
wants to merge 2 commits into from

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Mar 24, 2016

WIP

This is a rough initial implementation that I'm posting to get feedback and make sure I'm going in the right direction.

What's been done:

  • Created a new API GET /api/kibana/ingest/{patternId}/_fields which returns normalized field mapping info in the following form:
{
  "agent": {
    "type": "string",
    "indexed": true,
    "analyzed": true,
    "doc_values": false
  },
  "referer": {
    "type": "string",
    "indexed": true,
    "analyzed": false,
    "doc_values": true
  },
  ...
}
  • Updated client side code to pull field info from this API instead of directly from ES
  • Updated client side code to only store Kibana specific meta data in the index pattern fields field, like count and scripted fields.

Still needs:

  • Unit and API tests
  • Ensure all of the subtleties of mapping normalization have been carried over to the server side
  • Support date pattern based index patterns
    • Do we still need look back config?
  • Support metafields config option
  • Cleanup of now unused client side code
    • See if _mapper.js can be removed entirely
    • Update _create page to use new APIs via indexPatterns service instead of _mapper methods
  • Caching (server side or simply set cache control headers? I feel like we don't actually even need server side caching if we set sensible cache control headers)

@Bargs
Copy link
Contributor Author

Bargs commented Mar 24, 2016

@rashidkpc I'd love any feedback you might have. I split commits into API and client side work so it's easier to review each piece. Oh also, ignore the tests and added test fixtures for now, I pulled those in from my old branch and haven't updated them yet.

@rashidkpc
Copy link
Contributor

Holy crap ❤️

@Bargs
Copy link
Contributor Author

Bargs commented Mar 30, 2016

While working on this today I realized we also need access to the metaFields config property, so this might get blocked until I can move that config to the server. That or maybe I can continue to do the metaField filtering on the frontend for the time being.

@rashidkpc
Copy link
Contributor

WIP to add config service to server here: #6849

@epixa
Copy link
Contributor

epixa commented Oct 8, 2016

@Bargs Are you still planning to work on this PR?

@Bargs
Copy link
Contributor Author

Bargs commented Oct 10, 2016

Yep

@Bargs Bargs closed this Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants