Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/stats] fix git metadata collection #66840

Merged
merged 17 commits into from
May 19, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 16, 2020

When running preliminary reports for the ci-stats we've been collecting I've noticed that the mergeBase we're reporting seems to be off by a considerable amount, I'm not certain but it seems possible the logic which is pulling the latest changes from github is not pulling from the right host, so this attempts to clear that up by not using a named remote and instead use the repo url directly.

@kibanamachine

This comment has been minimized.

@spalger spalger marked this pull request as ready for review May 17, 2020 21:36
@spalger spalger requested a review from a team as a code owner May 17, 2020 21:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger added the release_note:skip Skip the PR/issue when compiling release notes label May 17, 2020
@spalger
Copy link
Contributor Author

spalger commented May 17, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@spalger
Copy link
Contributor Author

spalger commented May 17, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@spalger
Copy link
Contributor Author

spalger commented May 17, 2020

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

expected head sha didn’t match current head ref.

@spalger
Copy link
Contributor Author

spalger commented May 18, 2020

@elasticmachine merge upstream

@spalger spalger changed the title [ci/stats] fix merge base detection [ci/stats] fix git metadata collection May 18, 2020
@spalger
Copy link
Contributor Author

spalger commented May 18, 2020

@elasticmachine merge upstream

vars/getCheckoutInfo.groovy Outdated Show resolved Hide resolved
vars/getCheckoutInfo.groovy Outdated Show resolved Hide resolved
vars/getCheckoutInfo.groovy Outdated Show resolved Hide resolved
vars/workers.groovy Outdated Show resolved Hide resolved
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when green

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 9eaf0c0 into elastic:master May 19, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request May 19, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request May 19, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request May 19, 2020
spalger added a commit that referenced this pull request May 19, 2020
@spalger spalger added backport:skip This commit does not require backporting reverted labels May 19, 2020
@spalger
Copy link
Contributor Author

spalger commented May 19, 2020

This caused issues once merged to master because the branch reported is used to set the GIT_BRANCH env var outside of PRs and that branch is slightly different than it used to be. Need to validate that works going forward and resubmit.

gmmorris added a commit to gmmorris/kibana that referenced this pull request May 20, 2020
* master: (33 commits)
  [Saved Objects] adds support for including hidden types in saved objects client (elastic#66879)
  [Discover] Deangularize timechart header (elastic#66532)
  [Discover] Improve and unskip a11y context view test (elastic#66959)
  [SIEM] Refactor Timeline.timelineType draft to Timeline.status draft (elastic#66864)
  docs: update RUM documentation link (elastic#67042)
  [QA] fixup coverage ingestion tests. (elastic#66905)
  [Metrics UI] Add support for multiple groupings to Metrics Explorer (and Alerts) (elastic#66503)
  [Metrics UI] Add sorting for name and value to Inventory View (elastic#66644)
  [Metrics UI] Change Metric Threshold Alert charts to use bar charts (elastic#66672)
  [Uptime] Use React.lazy for alert type registration (elastic#66829)
  [Reporting] Consolidate API Integration Test configs (elastic#66637)
  Allow histogram fields in average and sum aggregations (elastic#66891)
  Fix saved object share link (elastic#66771)
  move role reset into the top level after clause (elastic#66971)
  Automate the labels for any PRs affecting files for the Ingest Management team (elastic#67022)
  [SIEMDPOINT] Move endpoint to siem (elastic#66907)
  server.uuid so is not used (elastic#66963)
  Revert "[ci/stats] fix git metadata collection (elastic#66840)"
  [Uptime] Unmount uptime app properly (elastic#66950)
  [Visualize] Bar chart: Show missing values on chart setting (elastic#66375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes reverted Team:Operations Team label for Operations Team v7.7.1 v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants