Prevents importing of public code into server

.eslintrc.js

@@ -197,6 +197,11 @@ module.exports = {
                 from: ['src/core/utils/**/*'],
                 errorMessage: `Plugins may only import from src/core/server and src/core/public.`,
               },
+              {
+                target: ['(src|x-pack)/plugins/*/server/**/*', '!x-pack/plugins/apm/**/*'],
+                from: ['(src|x-pack)/plugins/*/public/**/*'],
+                errorMessage: `Server code can not import from public, use a common directory.`,
+              },
               {
                 target: [
                   '(src|x-pack)/legacy/**/*',

src/plugins/apm_oss/server/index.ts

@@ -44,6 +44,8 @@ export { APMOSSPluginSetup } from './plugin';
 
 export { apmIndexPattern };
 
+export { APM_STATIC_INDEX_PATTERN_ID } from '../common/index_pattern_constants';
+
 export {
   createNodeAgentInstructions,
   createDjangoAgentInstructions,

src/plugins/es_ui_shared/public/authorization/index.ts → src/plugins/es_ui_shared/common/index.ts

@@ -17,4 +17,14 @@
  * under the License.
  */
 
-export * from '../../__packages_do_not_import__/authorization';
+export {
+  AuthorizationContext,
+  AuthorizationProvider,
+  NotAuthorizedSection,
+  WithPrivileges,
+  Privileges,
+  MissingPrivileges,
+  SectionError,
+  Error,
+  useAuthorizationContext,
+} from './authorization';

src/plugins/es_ui_shared/public/index.ts

@@ -47,18 +47,6 @@ export {
   expandLiteralStrings,
 } from './console_lang';
 
-export {
-  AuthorizationContext,
-  AuthorizationProvider,
-  NotAuthorizedSection,
-  WithPrivileges,
-  Privileges,
-  MissingPrivileges,
-  SectionError,
-  Error,
-  useAuthorizationContext,
-} from './authorization';
-
 /** dummy plugin, we just want esUiShared to have its own bundle */
 export function plugin() {
   return new (class EsUiSharedPlugin {

src/plugins/usage_collection/server/report/store_report.test.ts

@@ -20,7 +20,7 @@
 import { savedObjectsRepositoryMock } from '../../../../core/server/mocks';
 import { storeReport } from './store_report';
 import { ReportSchemaType } from './schema';
-import { METRIC_TYPE } from '../../public';
+import { METRIC_TYPE } from '@kbn/analytics';
 
 describe('store_report', () => {
   test('stores report for all types of data', async () => {

x-pack/plugins/alerting/server/alerts_client_factory.test.ts

@@ -11,7 +11,7 @@ import { taskManagerMock } from '../../../plugins/task_manager/server/task_manag
 import { KibanaRequest } from '../../../../src/core/server';
 import { loggingServiceMock, savedObjectsClientMock } from '../../../../src/core/server/mocks';
 import { encryptedSavedObjectsMock } from '../../../plugins/encrypted_saved_objects/server/mocks';
-import { AuthenticatedUser } from '../../../plugins/security/public';
+import { AuthenticatedUser } from '../../../plugins/security/common/model';
 import { securityMock } from '../../../plugins/security/server/mocks';
 
 jest.mock('./alerts_client');

x-pack/plugins/apm/server/lib/index_pattern/create_static_index_pattern.ts

@@ -4,8 +4,10 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { SavedObjectsErrorHelpers } from '../../../../../../src/core/server';
-import { apmIndexPattern } from '../../../../../../src/plugins/apm_oss/server';
-import { APM_STATIC_INDEX_PATTERN_ID } from '../../../../../../src/plugins/apm_oss/public';
+import {
+  apmIndexPattern,
+  APM_STATIC_INDEX_PATTERN_ID
+} from '../../../../../../src/plugins/apm_oss/server';
 import { hasHistoricalAgentData } from '../services/get_services/has_historical_agent_data';
 import { Setup } from '../helpers/setup_request';
 import { APMRequestHandlerContext } from '../../routes/typings';

x-pack/plugins/ingest_pipelines/public/shared_imports.ts

@@ -42,13 +42,14 @@ export {
 } from '../../../../src/plugins/es_ui_shared/static/validators/string';
 
 export {
-  SectionLoading,
   WithPrivileges,
   AuthorizationProvider,
   SectionError,
   Error,
   useAuthorizationContext,
   NotAuthorizedSection,
-} from '../../../../src/plugins/es_ui_shared/public';
+} from '../../../../src/plugins/es_ui_shared/common';
+
+export { SectionLoading } from '../../../../src/plugins/es_ui_shared/public';
 
 export const useKibana = () => _useKibana<AppServices>();

x-pack/plugins/ingest_pipelines/server/routes/api/privileges.ts

@@ -5,7 +5,7 @@
  */
 import { RouteDependencies } from '../../types';
 import { API_BASE_PATH, APP_CLUSTER_REQUIRED_PRIVILEGES } from '../../../common/constants';
-import { Privileges } from '../../../../../../src/plugins/es_ui_shared/public';
+import { Privileges } from '../../../../../../src/plugins/es_ui_shared/common';
 
 const extractMissingPrivileges = (privilegesObject: { [key: string]: boolean } = {}): string[] =>
   Object.keys(privilegesObject).reduce((privileges: string[], privilegeName: string): string[] => {

x-pack/plugins/siem/server/endpoint/alerts/handlers/lib/index.ts

@@ -6,7 +6,7 @@
 import { SearchResponse } from 'elasticsearch';
 import { IScopedClusterClient } from 'kibana/server';
 import { AlertEvent } from '../../../../../common/endpoint/types';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 import { esQuery } from '../../../../../../../../src/plugins/data/server';
 import {
   AlertAPIOrdering,

x-pack/plugins/siem/server/endpoint/routes/resolver/queries/base.ts

@@ -13,7 +13,7 @@ import {
   PaginationParams,
   PaginatedResults,
 } from '../utils/pagination';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 import { legacyEventIndexPattern } from './legacy_event_index_pattern';
 
 export abstract class ResolverQuery {

x-pack/plugins/siem/server/endpoint/routes/resolver/queries/events.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { ResolverQuery } from './base';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 
 export class EventsQuery extends ResolverQuery {
   protected legacyQuery(endpointID: string, uniquePIDs: string[], index: string): JsonObject {

x-pack/plugins/siem/server/endpoint/routes/resolver/queries/lifecycle.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 import { ResolverQuery } from './base';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 
 export class LifecycleQuery extends ResolverQuery {
   protected legacyQuery(endpointID: string, uniquePIDs: string[], index: string): JsonObject {

x-pack/plugins/siem/server/endpoint/routes/resolver/queries/stats.ts

@@ -6,7 +6,7 @@
 import { SearchResponse } from 'elasticsearch';
 import { ResolverQuery } from './base';
 import { ResolverEvent } from '../../../../../common/endpoint/types';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 import { PaginatedResults } from '../utils/pagination';
 
 export class StatsQuery extends ResolverQuery {

x-pack/plugins/siem/server/endpoint/routes/resolver/utils/pagination.ts

@@ -7,7 +7,7 @@
 import { SearchResponse } from 'elasticsearch';
 import { ResolverEvent } from '../../../../../common/endpoint/types';
 import { entityId } from '../../../../../common/endpoint/models/event';
-import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../../../../src/plugins/kibana_utils/common';
 
 export interface PaginationParams {
   size: number;

x-pack/plugins/siem/server/lib/types.ts

@@ -4,7 +4,7 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { AuthenticatedUser } from '../../../security/public';
+import { AuthenticatedUser } from '../../../security/common/model';
 import { RequestHandlerContext } from '../../../../../src/core/server';
 export { ConfigType as Configuration } from '../config';
 

x-pack/plugins/siem/server/utils/serialized_query.ts

@@ -7,7 +7,7 @@
 import { UserInputError } from 'apollo-server-errors';
 import { isEmpty, isPlainObject, isString } from 'lodash/fp';
 
-import { JsonObject } from '../../../../../src/plugins/kibana_utils/public';
+import { JsonObject } from '../../../../../src/plugins/kibana_utils/common';
 
 export const parseFilterQuery = (filterQuery: string): JsonObject => {
   try {

x-pack/plugins/snapshot_restore/public/shared_imports.ts

@@ -5,17 +5,20 @@
  */
 
 export {
+  CronEditor,
+  DAY,
+  sendRequest,
   SendRequestConfig,
   SendRequestResponse,
-  UseRequestConfig,
-  sendRequest,
   useRequest,
-  CronEditor,
-  DAY,
-  SectionError,
+  UseRequestConfig,
+} from '../../../../src/plugins/es_ui_shared/public';
+
+export {
+  AuthorizationProvider,
   Error,
-  WithPrivileges,
-  useAuthorizationContext,
   NotAuthorizedSection,
-  AuthorizationProvider,
-} from '../../../../src/plugins/es_ui_shared/public';
+  SectionError,
+  useAuthorizationContext,
+  WithPrivileges,
+} from '../../../../src/plugins/es_ui_shared/common';

x-pack/plugins/snapshot_restore/server/routes/api/app.ts

@@ -3,7 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import { Privileges } from '../../../../../../src/plugins/es_ui_shared/public';
+import { Privileges } from '../../../../../../src/plugins/es_ui_shared/common';
 
 import {
   APP_REQUIRED_CLUSTER_PRIVILEGES,