[Maps] surface geo_shape clustering gold feature #68666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Super useful. I also like how the license-checking is dynamic. Updating a license will just magically fix an open instance of Maps, not even requiring page-refresh.
Only nits really, for your consideration. Mainly some suggestions to tweak the wording of the messages to make it more explicit.
x-pack/plugins/maps/public/classes/sources/es_geo_grid_source/create_source_editor.js
Show resolved
Hide resolved
thomasneirynck
approved these changes
Jun 11, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 12, 2020
* [Maps] surface geo_shape clustering gold feature * show gold in scaling form * tslint * more tslint changes * fix jest test * fix functional test by handling fields prop being undefined * tslint fixes - that thing is slow to run * review feedback * update doc_values missing copy Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jun 12, 2020
* [Maps] surface geo_shape clustering gold feature * show gold in scaling form * tslint * more tslint changes * fix jest test * fix functional test by handling fields prop being undefined * tslint fixes - that thing is slow to run * review feedback * update doc_values missing copy Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
that referenced
this pull request
Jun 12, 2020
* [Maps] surface geo_shape clustering gold feature * show gold in scaling form * tslint * more tslint changes * fix jest test * fix functional test by handling fields prop being undefined * tslint fixes - that thing is slow to run * review feedback * update doc_values missing copy Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67530
This PR surfaces geo_shape clustering gold features when gold license is not provided.
In "Clusters and grids" and "Heat map" layer wizard, geo_shape fields are displayed in the geo field select. They are disabled with a tooltip explaining why they are disabled.
In "Documents" layer wizard, Scaling form displays clustering option.