[6.8] Support deep links inside of RelayState for SAML IdP initiated login.
#69663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
commented
Jun 23, 2020
| return `${basePath}/`; | ||
| } | ||
|
|
||
| let next: string; |
There was a problem hiding this comment.
note: we didn't have this check in 6.8 before, but it seems it's better to have it.
azasypkin
force-pushed
the
6.8-relay-state-saml
branch
from
1815c2f
to
93fe32d
Compare
azasypkin
commented
Jun 24, 2020
| @@ -45,6 +46,12 @@ export const security = (kibana) => new kibana.Plugin({ | |||
| hostname: Joi.string().hostname(), | |||
| port: Joi.number().integer().min(0).max(65535) | |||
| }).default(), | |||
| authc: Joi.object({}) | |||
There was a problem hiding this comment.
note: even though we drop it in 7.0 I wanted it to look similar to what we have in 7.2+.
azasypkin
commented
Jun 24, 2020
| server, | ||
| providerType | ||
| ) { | ||
| // We can't use `config.has` here as it doesn't currently work with Joi's "alternatives" syntax |
There was a problem hiding this comment.
note: borrowed from Ioannis's PR where he introduced OIDC.
|
Hey @legrego, This backport is essentially a different PR, would be great if you can take a brief look. Thanks! |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: #69401