Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Allow to configure Event Renderers settings #69693

Merged

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jun 23, 2020

Summary

Adds a "cog" icon to the Events table that allows configuring which Event Renderers should be used.

image

image

Checklist

patrykkopycinski and others added 20 commits June 23, 2020 18:58
…erers-settings

# Conflicts:
#	x-pack/plugins/security_solution/common/types/timeline/index.ts
#	x-pack/plugins/security_solution/public/timelines/components/open_timeline/types.ts
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/__snapshots__/index.test.tsx.snap
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/column_headers/index.tsx
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.tsx
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/stateful_body.tsx
#	x-pack/plugins/security_solution/public/timelines/store/timeline/helpers.ts
#	x-pack/plugins/security_solution/public/timelines/store/timeline/model.ts
* Added a subtitle: `Event Renderers automatically convey the most relevant details in an event to reveal its story`
* Renamed some renderers
…erers-settings

# Conflicts:
#	x-pack/plugins/security_solution/public/common/components/drag_and_drop/draggable_wrapper.tsx
#	x-pack/plugins/security_solution/public/timelines/components/timeline/body/index.tsx
@patrykkopycinski patrykkopycinski removed request for a team July 9, 2020 11:45
@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

elasticmachine and others added 4 commits July 9, 2020 09:12
…erers-settings

# Conflicts:
#	x-pack/plugins/security_solution/public/graphql/types.ts
#	x-pack/plugins/security_solution/public/timelines/store/timeline/helpers.ts
#	x-pack/plugins/security_solution/server/graphql/types.ts
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature @patrykkopycinski! 🙏
Looks good locally
LGTM 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 822 +1 821

Saved Objects .kibana field count

id value diff baseline
siem-ui-timeline 89 +1 88

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit b24632d into elastic:master Jul 10, 2020
@patrykkopycinski patrykkopycinski deleted the feat/row-renderers-settings branch July 10, 2020 13:05
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Jul 10, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 13, 2020
* master: (78 commits)
  Bump lodash package version (elastic#71392)
  refactor: 💡 use allow-list in AppArch codebase (elastic#71400)
  improve bugfix 7198 test stability (elastic#71250)
  [Security Solution][Ingest Manager][Endpoint] Optional ingest manager (elastic#71198)
  [Metrics UI] Round metric threshold time buckets to nearest unit (elastic#71172)
  [Security Solution][Endpoint] Policy creation callback fixes + Improved error handling in user manifest loop (elastic#71269)
  [Security Solution] Allow to configure Event Renderers settings (elastic#69693)
  Fix a11y keyboard overlay (elastic#71214)
  [APM] UI text updates (elastic#71333)
  [Logs UI] Limit `extendDatemath` to valid ranges (elastic#71113)
  [SIEM] fix tooltip of notes (elastic#71342)
  address index templates feedback (elastic#71353)
  Upgrade EUI to v26.3.1 (elastic#70243)
  [build] Creates Linux aarch64 archive (elastic#69165)
  [SIEM][Detection Engine] Fixes skipped tests (elastic#71347)
  [SIEM][Detection Engine][Lists] Adds read_privileges route for lists and list items
  [kbn/optimizer] implement "requiredBundles" property of KP plugins (elastic#70911)
  [Security Solution][Exceptions] - Exceptions modal pt 2 (elastic#70886)
  [ML] DF Analytics:  stop status polling when job stopped (elastic#71159)
  [SIEM][CASE] IBM Resilient Connector (elastic#66385)
  ...
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants