Issue 63621 Fix Flaky Tests #70344
Merged
Issue 63621 Fix Flaky Tests #70344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlie-pichette
added
v8.0.0
release_note:skip
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
kevinlog
approved these changes
Jun 30, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
charlie-pichette
added a commit
to charlie-pichette/kibana
that referenced
this pull request
Jul 1, 2020
charlie-pichette
added a commit
that referenced
this pull request
Jul 1, 2020
|
This also fixes #61284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The endpoint list tests were failing intermittently. This appears to be due to the loading, deleting and loading data. This PR refactors the tests into to primary describe blocks, one for when there is no data and one for when there is data.
There is a set of tests that are intended to navigate to the page directly with a specific endpoint to test the flyout appears immediately. These are currently not working properly and I have added the skip until we can get them working.
Fixes #63621.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately