[Security Solution] [DETECTIONS] Set rule status to failure only on large gaps #71549

dhurley14 · 2020-07-13T21:29:44Z

Summary

This is a follow-on PR to update the UX for when an error appears on the UI when a rule runs into a gap.

Previously, we were writing a failing status for a rule whenever a gap occurred. This PR introduces logic to write a failing rule status only if the calculated gap is very large (equivalent to 4x the rule interval). Otherwise don't write a status until rule execution has completed.

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

… code to cover, general code cleanup, adds some tests for separate function

…up, ratio, and gapDiffInUnits properties

elasticmachine · 2020-07-13T22:48:15Z

Pinging @elastic/siem (Team:SIEM)

…n calculating gapDiffInUnits in getGapMaxCatchupRatio fn

FrankHassanabad

LGTM

kibanamachine · 2020-07-14T22:03:56Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 6c9f991
Flaky suites:
- xpack-kibana-ciGroup10

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/embeddable/dashboard·js.maps app embeddable embed in dashboard should populate inspector with requests for map embeddable

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: maps app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ info [logstash_functional] Loading "mappings.json"
[00:00:00]             │ info [logstash_functional] Loading "data.json.gz"
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [logstash-2015.09.22] creating index, cause [api], templates [], shards [1]/[0]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.22][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.22][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.22"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.22" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [logstash-2015.09.20] creating index, cause [api], templates [], shards [1]/[0]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.20][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.20][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.20"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.20" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:00]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [logstash-2015.09.21] creating index, cause [api], templates [], shards [1]/[0]
[00:00:00]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.21][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.21][0]]"
[00:00:00]             │ info [logstash_functional] Created index "logstash-2015.09.21"
[00:00:00]             │ debg [logstash_functional] "logstash-2015.09.21" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:10]             │ info progress: 8126
[00:00:14]             │ info [logstash_functional] Indexed 4634 docs into "logstash-2015.09.22"
[00:00:14]             │ info [logstash_functional] Indexed 4757 docs into "logstash-2015.09.20"
[00:00:14]             │ info [logstash_functional] Indexed 4614 docs into "logstash-2015.09.21"
[00:00:15]             │ info [maps/data] Loading "mappings.json"
[00:00:15]             │ info [maps/data] Loading "data.json"
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[geo_shapes][0]]])." previous.health="YELLOW" reason="shards started [[geo_shapes][0]]"
[00:00:15]             │ info [maps/data] Created index "geo_shapes"
[00:00:15]             │ debg [maps/data] "geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [meta_for_geo_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[meta_for_geo_shapes][0]]])." previous.health="YELLOW" reason="shards started [[meta_for_geo_shapes][0]]"
[00:00:15]             │ info [maps/data] Created index "meta_for_geo_shapes"
[00:00:15]             │ debg [maps/data] "meta_for_geo_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [antimeridian_points] creating index, cause [api], templates [], shards [1]/[0]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[antimeridian_points][0]]])." previous.health="YELLOW" reason="shards started [[antimeridian_points][0]]"
[00:00:15]             │ info [maps/data] Created index "antimeridian_points"
[00:00:15]             │ debg [maps/data] "antimeridian_points" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [antimeridian_shapes] creating index, cause [api], templates [], shards [1]/[0]
[00:00:15]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[antimeridian_shapes][0]]])." previous.health="YELLOW" reason="shards started [[antimeridian_shapes][0]]"
[00:00:15]             │ info [maps/data] Created index "antimeridian_shapes"
[00:00:15]             │ debg [maps/data] "antimeridian_shapes" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:15]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [flights] creating index, cause [api], templates [], shards [1]/[0]
[00:00:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[flights][0]]])." previous.health="YELLOW" reason="shards started [[flights][0]]"
[00:00:16]             │ info [maps/data] Created index "flights"
[00:00:16]             │ debg [maps/data] "flights" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:16]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [connections] creating index, cause [api], templates [], shards [1]/[0]
[00:00:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[connections][0]]])." previous.health="YELLOW" reason="shards started [[connections][0]]"
[00:00:16]             │ info [maps/data] Created index "connections"
[00:00:16]             │ debg [maps/data] "connections" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [meta_for_geo_shapes/pZ3-NzkDSr6-tgSpnzyfPQ] update_mapping [_doc]
[00:00:16]             │ info [maps/data] Indexed 4 docs into "geo_shapes"
[00:00:16]             │ info [maps/data] Indexed 6 docs into "meta_for_geo_shapes"
[00:00:16]             │ info [maps/data] Indexed 3 docs into "antimeridian_points"
[00:00:16]             │ info [maps/data] Indexed 3 docs into "antimeridian_shapes"
[00:00:16]             │ info [maps/data] Indexed 3 docs into "flights"
[00:00:16]             │ info [maps/data] Indexed 4 docs into "connections"
[00:00:16]             │ info [maps/kibana] Loading "mappings.json"
[00:00:16]             │ info [maps/kibana] Loading "data.json"
[00:00:16]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_1/qKEgRhlzT6uelaxYmV_yJQ] deleting index
[00:00:16]             │ info [maps/kibana] Deleted existing index [".kibana_1"]
[00:00:16]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana] creating index, cause [api], templates [], shards [1]/[0]
[00:00:16]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana][0]]])." previous.health="YELLOW" reason="shards started [[.kibana][0]]"
[00:00:16]             │ info [maps/kibana] Created index ".kibana"
[00:00:16]             │ debg [maps/kibana] ".kibana" settings {"index":{"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana/RcjhA_YtRXKeJjDtrEjr5g] update_mapping [_doc]
[00:00:16]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana/RcjhA_YtRXKeJjDtrEjr5g] update_mapping [_doc]
[00:00:17]             │ info [maps/kibana] Indexed 29 docs into ".kibana"
[00:00:17]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana/RcjhA_YtRXKeJjDtrEjr5g] update_mapping [_doc]
[00:00:17]             │ debg Migrating saved objects
[00:00:17]             │ proc [kibana]   log   [20:57:55.781] [info][savedobjects-service] Creating index .kibana_2.
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] updating number_of_replicas to [0] for indices [.kibana_2]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_2][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_2][0]]"
[00:00:17]             │ proc [kibana]   log   [20:57:55.917] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] updating number_of_replicas to [0] for indices [.kibana_1]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_1][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_1][0]]"
[00:00:17]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.tasks] creating index, cause [auto(task api)], templates [], shards [1]/[1]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] updating number_of_replicas to [0] for indices [.tasks]
[00:00:17]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.tasks][0]]])." previous.health="YELLOW" reason="shards started [[.tasks][0]]"
[00:00:17]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] 2057 finished with response BulkByScrollResponse[took=156.1ms,timed_out=false,sliceId=null,updated=0,created=29,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:00:18]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana/RcjhA_YtRXKeJjDtrEjr5g] deleting index
[00:00:18]             │ proc [kibana]   log   [20:57:56.629] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2/EfKltiJYS0Sul1HdZF45zw] update_mapping [_doc]
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2/EfKltiJYS0Sul1HdZF45zw] update_mapping [_doc]
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2/EfKltiJYS0Sul1HdZF45zw] update_mapping [_doc]
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2/EfKltiJYS0Sul1HdZF45zw] update_mapping [_doc]
[00:00:18]             │ proc [kibana]   log   [20:57:57.015] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:00:18]             │ proc [kibana]   log   [20:57:57.083] [info][savedobjects-service] Finished in 1304ms.
[00:00:18]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:00:18]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-16-tests-xl-1594758035187523775] [.kibana_2/EfKltiJYS0Sul1HdZF45zw] update_mapping [_doc]
[00:00:20]             │ debg replacing kibana config doc: {"defaultIndex":"c698b940-e149-11e8-a35a-370a8516603a"}
[00:00:21]           └-: 
[00:00:21]             └-> "before all" hook
[00:19:02]             └-: embeddable
[00:19:02]               └-> "before all" hook
[00:19:02]               └-: embed in dashboard
[00:19:02]                 └-> "before all" hook
[00:19:02]                 └-> "before all" hook
[00:19:02]                   │ debg replacing kibana config doc: {"defaultIndex":"c698b940-e149-11e8-a35a-370a8516603a","courier:ignoreFilterIfFieldNotInIndex":true}
[00:19:03]                   │ debg navigating to dashboard url: http://localhost:61111/app/dashboards#/list
[00:19:03]                   │ debg navigate to: http://localhost:61111/app/dashboards#/list
[00:19:03]                   │ debg browser[INFO] http://localhost:61111/app/dashboards?_t=1594761402246#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:03]                   │
[00:19:03]                   │ debg browser[INFO] http://localhost:61111/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:03]                   │ debg ... sleep(700) start
[00:19:04]                   │ debg ... sleep(700) end
[00:19:04]                   │ debg returned from get, calling refresh
[00:19:06]                   │ debg browser[INFO] http://localhost:61111/34616/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-14T21:16:43Z
[00:19:06]                   │        Adding connection to http://localhost:61111/elasticsearch
[00:19:06]                   │
[00:19:06]                   │      "
[00:19:06]                   │ERROR browser[SEVERE] http://localhost:61111/34616/bundles/core/core.entry.js 83:261771 TypeError: Failed to fetch
[00:19:06]                   │ debg browser[INFO] http://localhost:61111/app/dashboards?_t=1594761402246#/list 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:19:06]                   │
[00:19:06]                   │ debg browser[INFO] http://localhost:61111/bundles/app/core/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:19:06]                   │ debg currentUrl = http://localhost:61111/app/dashboards#/list
[00:19:06]                   │          appUrl = http://localhost:61111/app/dashboards#/list
[00:19:06]                   │ debg TestSubjects.find(kibanaChrome)
[00:19:06]                   │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:19:08]                   │ debg browser[INFO] http://localhost:61111/34616/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-07-14T21:16:46Z
[00:19:08]                   │        Adding connection to http://localhost:61111/elasticsearch
[00:19:08]                   │
[00:19:08]                   │      "
[00:19:08]                   │ debg ... sleep(501) start
[00:19:08]                   │ debg ... sleep(501) end
[00:19:08]                   │ debg in navigateTo url = http://localhost:61111/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:19:08]                   │ debg --- retry.try error: URL changed, waiting for it to settle
[00:19:09]                   │ debg ... sleep(501) start
[00:19:09]                   │ debg ... sleep(501) end
[00:19:09]                   │ debg in navigateTo url = http://localhost:61111/app/dashboards#/list?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:19:09]                   │ debg TestSubjects.exists(statusPageContainer)
[00:19:09]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:19:12]                   │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:19:13]                   │ debg Load Saved Dashboard map embeddable example
[00:19:13]                   │ debg gotoDashboardLandingPage
[00:19:13]                   │ debg onDashboardLandingPage
[00:19:13]                   │ debg TestSubjects.exists(dashboardLandingPage)
[00:19:13]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:19:13]                   │ debg searchForItemWithName: map embeddable example
[00:19:13]                   │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:19:13]                   │ debg isGlobalLoadingIndicatorVisible
[00:19:13]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:19:13]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:19:13]                   │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:19:15]                   │ debg --- retry.tryForTime failed again with the same message...
[00:19:16]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:16]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:16]                   │ debg TestSubjects.click(dashboardListingTitleLink-map-embeddable-example)
[00:19:16]                   │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-map-embeddable-example"]') with timeout=10000
[00:19:16]                   │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-map-embeddable-example"]') with timeout=10000
[00:19:16]                   │ debg isGlobalLoadingIndicatorVisible
[00:19:16]                   │ debg TestSubjects.exists(globalLoadingIndicator)
[00:19:16]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:19:17]                   │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:19:17]                   │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:19:17]                   │ debg TestSubjects.missingOrFail(dashboardLandingPage)
[00:19:17]                   │ debg Find.waitForDeletedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=10000
[00:19:18]                 └-> should pass index patterns to container
[00:19:18]                   └-> "before each" hook: global before each
[00:19:18]                   │ debg TestSubjects.click(addFilter)
[00:19:18]                   │ debg Find.clickByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:19:18]                   │ debg Find.findByCssSelector('[data-test-subj="addFilter"]') with timeout=10000
[00:19:19]                   │ debg comboBox.getOptionsList, comboBoxSelector: filterIndexPatternsSelect
[00:19:19]                   │ debg TestSubjects.find(filterIndexPatternsSelect)
[00:19:19]                   │ debg Find.findByCssSelector('[data-test-subj="filterIndexPatternsSelect"]') with timeout=10000
[00:19:19]                   │ debg TestSubjects.click(filterIndexPatternsSelect)
[00:19:19]                   │ debg Find.clickByCssSelector('[data-test-subj="filterIndexPatternsSelect"]') with timeout=10000
[00:19:19]                   │ debg Find.findByCssSelector('[data-test-subj="filterIndexPatternsSelect"]') with timeout=10000
[00:19:20]                   │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:19:20]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:19:20]                   │ debg TestSubjects.find(~comboBoxOptionsList)
[00:19:20]                   │ debg Find.findByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=10000
[00:19:20]                   │ debg TestSubjects.exists(~comboBoxOptionsList)
[00:19:20]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj~="comboBoxOptionsList"]') with timeout=2500
[00:19:21]                   │ debg TestSubjects.exists(cancelSaveFilter)
[00:19:21]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="cancelSaveFilter"]') with timeout=2500
[00:19:21]                   │ debg TestSubjects.click(cancelSaveFilter)
[00:19:21]                   │ debg Find.clickByCssSelector('[data-test-subj="cancelSaveFilter"]') with timeout=10000
[00:19:21]                   │ debg Find.findByCssSelector('[data-test-subj="cancelSaveFilter"]') with timeout=10000
[00:19:21]                   │ debg Find.waitForDeletedByCssSelector('[data-test-subj="cancelSaveFilter"]') with timeout=10000
[00:19:22]                   └- ✓ pass  (4.1s) "maps app  embeddable embed in dashboard should pass index patterns to container"
[00:19:22]                 └-> should populate inspector with requests for map embeddable
[00:19:22]                   └-> "before each" hook: global before each
[00:19:22]                   │ debg TestSubjects.find(embeddablePanelHeading-joinexample)
[00:19:22]                   │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelHeading-joinexample"]') with timeout=10000
[00:19:22]                   │ debg openContextMenu([object Object]
[00:19:22]                   │ debg toggleContextMenu
[00:19:22]                   │ debg TestSubjects.findDescendant(embeddablePanelToggleMenuIcon)
[00:19:22]                   │ debg Find.descendantDisplayedByCssSelector('[data-test-subj="embeddablePanelToggleMenuIcon"]')
[00:19:22]                   │ debg TestSubjects.exists(embeddablePanelContextMenuOpen)
[00:19:22]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="embeddablePanelContextMenuOpen"]') with timeout=120000
[00:19:22]                   │ debg TestSubjects.click(embeddablePanelAction-openInspector)
[00:19:22]                   │ debg Find.clickByCssSelector('[data-test-subj="embeddablePanelAction-openInspector"]') with timeout=10000
[00:19:22]                   │ debg Find.findByCssSelector('[data-test-subj="embeddablePanelAction-openInspector"]') with timeout=10000
[00:19:22]                   │ debg Open Inspector view inspectorViewChooserRequests
[00:19:22]                   │ debg TestSubjects.click(inspectorViewChooser)
[00:19:22]                   │ debg Find.clickByCssSelector('[data-test-subj="inspectorViewChooser"]') with timeout=10000
[00:19:22]                   │ debg Find.findByCssSelector('[data-test-subj="inspectorViewChooser"]') with timeout=10000
[00:19:22]                   │ debg TestSubjects.click(inspectorViewChooserRequests)
[00:19:22]                   │ debg Find.clickByCssSelector('[data-test-subj="inspectorViewChooserRequests"]') with timeout=10000
[00:19:22]                   │ debg Find.findByCssSelector('[data-test-subj="inspectorViewChooserRequests"]') with timeout=10000
[00:19:23]                   │ debg TestSubjects.exists(inspectorRequestChooser)
[00:19:23]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorRequestChooser"]') with timeout=2500
[00:19:23]                   │ debg TestSubjects.click(inspectorRequestChooser)
[00:19:23]                   │ debg Find.clickByCssSelector('[data-test-subj="inspectorRequestChooser"]') with timeout=10000
[00:19:23]                   │ debg Find.findByCssSelector('[data-test-subj="inspectorRequestChooser"]') with timeout=10000
[00:19:23]                   │ debg TestSubjects.find(inspectorRequestChooserMenuPanel)
[00:19:23]                   │ debg Find.findByCssSelector('[data-test-subj="inspectorRequestChooserMenuPanel"]') with timeout=10000
[00:19:23]                   │ debg Close Inspector
[00:19:23]                   │ debg TestSubjects.exists(inspectorPanel)
[00:19:23]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:19:23]                   │ debg Closing flyout inspectorPanel
[00:19:23]                   │ debg TestSubjects.find(inspectorPanel)
[00:19:23]                   │ debg Find.findByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=10000
[00:19:23]                   │ debg Waiting up to 20000ms for flyout closed...
[00:19:23]                   │ debg TestSubjects.exists(inspectorPanel)
[00:19:23]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=1000
[00:19:24]                   │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:19:24]                   │ debg TestSubjects.exists(inspectorPanel)
[00:19:24]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="inspectorPanel"]') with timeout=2500
[00:19:27]                   │ debg --- retry.tryForTime error: [data-test-subj="inspectorPanel"] is not displayed
[00:19:28]                   │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/maps app  embeddable embed in dashboard should populate inspector with requests for map embeddable.png"
[00:19:28]                   │ info Current URL is: http://localhost:61111/app/dashboards#/view/19906970-2e40-11e9-85cb-6965aae20f13?_g=(filters:!(),refreshInterval:(pause:!t,value:1000),time:(from:%272015-09-20T00:00:00.000Z%27,to:%272015-09-20T01:00:00.000Z%27))&_a=(description:%27%27,filters:!(),fullScreenMode:!f,options:(darkTheme:!f,hidePanelTitles:!f,useMargins:!t),query:(language:lucene,query:%27%27),timeRestore:!t,title:%27map%20embeddable%20example%27,viewMode:view)
[00:19:28]                   │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/maps app  embeddable embed in dashboard should populate inspector with requests for map embeddable.html
[00:19:28]                   └- ✖ fail: maps app  embeddable embed in dashboard should populate inspector with requests for map embeddable
[00:19:28]                   │      Error: expected '' to equal 'geo_shapes*,meta_for_geo_shapes*.shape_name'
[00:19:28]                   │       at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
[00:19:28]                   │       at Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
[00:19:28]                   │       at Context.it (test/functional/apps/maps/embeddable/dashboard.js:55:42)
[00:19:28]                   │ 
[00:19:28]                   │

Stack Trace

Error: expected '' to equal 'geo_shapes*,meta_for_geo_shapes*.shape_name'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.equal (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:227:8)
    at Context.it (test/functional/apps/maps/embeddable/dashboard.js:55:42)

Build metrics

✅ unchanged

History

💔 Build #61512 failed a41545c
💔 Build #61161 failed 22bab0d
💔 Build #61116 failed 14d5231

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…y on large gaps (#71549) (#71782) Only display rule error status if a large gap is present

elasticmachine · 2021-09-23T14:31:25Z

Pinging @elastic/security-solution (Team: SecuritySolution)

dhurley14 added 2 commits July 13, 2020 18:07

only display gap error when a gap is too large for the gap mitigation…

e22556f

… code to cover, general code cleanup, adds some tests for separate function

removes throwing of errors and log error and return null for maxCatch…

6f1c9e3

…up, ratio, and gapDiffInUnits properties

dhurley14 force-pushed the gap-detection-ui-warning branch from 14d5231 to 6f1c9e3 Compare July 13, 2020 22:38

forgot to delete commented out code

e463ffc

dhurley14 self-assigned this Jul 13, 2020

dhurley14 added Feature:Detection Rules Anything related to Security Solution's Detection Rules release_note:enhancement review Team:SIEM v7.9.0 v8.0.0 labels Jul 13, 2020

dhurley14 marked this pull request as ready for review July 13, 2020 22:48

dhurley14 requested review from a team as code owners July 13, 2020 22:48

remove math.abs since we fixed this bug by switching around logic whe…

22bab0d

…n calculating gapDiffInUnits in getGapMaxCatchupRatio fn

FrankHassanabad approved these changes Jul 13, 2020

View reviewed changes

dhurley14 added 2 commits July 14, 2020 13:08

updates tests for when a gap error should be written to rule status

a41545c

fix typo

6c9f991

dhurley14 merged commit e42630d into elastic:master Jul 14, 2020

dhurley14 deleted the gap-detection-ui-warning branch July 14, 2020 22:08

dhurley14 mentioned this pull request Jul 14, 2020

[7.x] [Security Solution] [DETECTIONS] Set rule status to failure only on large gaps (#71549) #71782

Merged

dhurley14 added a commit that referenced this pull request Jul 15, 2020

[7.x] [Security Solution] [DETECTIONS] Set rule status to failure onl…

5cad3fa

…y on large gaps (#71549) (#71782) Only display rule error status if a large gap is present

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] [DETECTIONS] Set rule status to failure only on large gaps #71549

[Security Solution] [DETECTIONS] Set rule status to failure only on large gaps #71549

dhurley14 commented Jul 13, 2020 •

edited

elasticmachine commented Jul 13, 2020

FrankHassanabad left a comment

kibanamachine commented Jul 14, 2020

Standard Out

Stack Trace

elasticmachine commented Sep 23, 2021

[Security Solution] [DETECTIONS] Set rule status to failure only on large gaps #71549

[Security Solution] [DETECTIONS] Set rule status to failure only on large gaps #71549

Conversation

dhurley14 commented Jul 13, 2020 • edited

Summary

Checklist

For maintainers

elasticmachine commented Jul 13, 2020

FrankHassanabad left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 14, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

History

elasticmachine commented Sep 23, 2021

dhurley14 commented Jul 13, 2020 •

edited