Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add data] Suppress processor error messages until user dirties the form #7340

Merged
merged 4 commits into from
Jun 7, 2016
Merged

[add data] Suppress processor error messages until user dirties the form #7340

merged 4 commits into from
Jun 7, 2016

Conversation

BigFunger
Copy link
Contributor

Summary

Before this PR, when the user would add a new processor to the pipeline, it would be added in an error state. This is jogging to the user because it makes them think that they have done something wrong, when in fact they haven't.

Changes

  • Added a new property to the processor base class
  • Added logic to the pipeline class which causes it to essentially ignore processors with this new flag set
  • Added an angular form to the processor container directive. Also added a watch that sets the new flag when the form leave its pristine state
  • Reordered the elements on the processor container view so that the error message and the processor output are located in the same spot. This reduces the 'jumping' of the form when the processor goes into or out of error state. Also, the processor output is hidden when the processor is in an error state.

@alt74 I would like your input on the rearrangement of the elements on the view mentioned above.

@BigFunger BigFunger added review Feature:Add Data Add Data and sample data feature on Home labels Jun 1, 2016
@Bargs
Copy link
Contributor

Bargs commented Jun 2, 2016

@BigFunger what's the benefit of maintaining a new flag manually over using the $dirty flag from the form or input?

Bargs
Bargs reviewed Jun 2, 2016
View reviewed changes
...settings/sections/indices/add_data_steps/pipeline_setup/directives/processor_ui_container.js
const $innerEl = angular.element(template);
const postLink = $compile($innerEl);
$container.append($innerEl);
postLink(newScope);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help me understand what this change is doing?

@Bargs
Copy link
Contributor

Bargs commented Jun 2, 2016

I think I mentioned this on Slack, but it looks like this has legitimate test failures as well.

@Bargs Bargs assigned BigFunger and unassigned Bargs Jun 2, 2016
@BigFunger BigFunger assigned alt74 and unassigned BigFunger Jun 3, 2016
@alt74
Copy link

alt74 commented Jun 3, 2016

@BigFunger LGTM design wise :)

@BigFunger BigFunger assigned BigFunger and Bargs and unassigned alt74 and BigFunger Jun 6, 2016
@Bargs
Copy link
Contributor

Bargs commented Jun 7, 2016

LGTM

@BigFunger BigFunger merged commit 34fa17b into elastic:feature/ingest-pipeline Jun 7, 2016
cee-chen added a commit that referenced this pull request Jan 10, 2024
@cee-chen
Upgrade EUI to v92.0.0 (#174487)
517763e 
`v91.3.1`⏩`v92.0.0-backport.0`

---

##
[`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

**Bug fixes**

- Fixed an `EuiTreeView` JSX Typescript error
([#7452](elastic/eui#7452))
- Fixed a color console warning being generated by disabled `EuiStep`s
([#7454](elastic/eui#7454))


## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0)

- Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and
`EuiSearchBar.Query.execute` to add `extends object` constraint
([#7340](elastic/eui#7340))
- This change should have no impact on your applications since the
updated types only affect properties that exclusively accept object
values.
- Added a new `EuiFlyoutResizable` component
([#7439](elastic/eui#7439))
- Updated `EuiTextArea` to accept `isClearable` and `icon` as props
([#7449](elastic/eui#7449))

**Bug fixes**

- `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their
positions on resize ([#7442](elastic/eui#7442))

**Deprecations**

- Updated `EuiFilterButton` to remove the second
`.euiFilterButton__textShift` span wrapper. Target
`.euiFilterButton__text` instead
([#7444](elastic/eui#7444))

**Breaking changes**

- Removed deprecated `EuiNotificationEvent`. We recommend copying the
component to your application if necessary
([#7434](elastic/eui#7434))
- Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar`
instead ([#7435](elastic/eui#7435))
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 11, 2024
@cee-chen @delanni
Upgrade EUI to v92.0.0 (elastic#174487)
9cd82db 
`v91.3.1`⏩`v92.0.0-backport.0`

---

##
[`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

**Bug fixes**

- Fixed an `EuiTreeView` JSX Typescript error
([elastic#7452](elastic/eui#7452))
- Fixed a color console warning being generated by disabled `EuiStep`s
([elastic#7454](elastic/eui#7454))


## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0)

- Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and
`EuiSearchBar.Query.execute` to add `extends object` constraint
([elastic#7340](elastic/eui#7340))
- This change should have no impact on your applications since the
updated types only affect properties that exclusively accept object
values.
- Added a new `EuiFlyoutResizable` component
([elastic#7439](elastic/eui#7439))
- Updated `EuiTextArea` to accept `isClearable` and `icon` as props
([elastic#7449](elastic/eui#7449))

**Bug fixes**

- `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their
positions on resize ([elastic#7442](elastic/eui#7442))

**Deprecations**

- Updated `EuiFilterButton` to remove the second
`.euiFilterButton__textShift` span wrapper. Target
`.euiFilterButton__text` instead
([elastic#7444](elastic/eui#7444))

**Breaking changes**

- Removed deprecated `EuiNotificationEvent`. We recommend copying the
component to your application if necessary
([elastic#7434](elastic/eui#7434))
- Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar`
instead ([elastic#7435](elastic/eui#7435))
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
@cee-chen @CoenWarmer
Upgrade EUI to v92.0.0 (elastic#174487)
1bdf7bf 
`v91.3.1`⏩`v92.0.0-backport.0`

---

##
[`v92.0.0-backport.0`](https://github.com/elastic/eui/releases/v92.0.0-backport.0)

**This is a backport release only intended for use by Kibana.**

**Bug fixes**

- Fixed an `EuiTreeView` JSX Typescript error
([elastic#7452](elastic/eui#7452))
- Fixed a color console warning being generated by disabled `EuiStep`s
([elastic#7454](elastic/eui#7454))


## [`v92.0.0`](https://github.com/elastic/eui/releases/v92.0.0)

- Updated generic types of `EuiBasicTable`, `EuiInMemoryTable` and
`EuiSearchBar.Query.execute` to add `extends object` constraint
([elastic#7340](elastic/eui#7340))
- This change should have no impact on your applications since the
updated types only affect properties that exclusively accept object
values.
- Added a new `EuiFlyoutResizable` component
([elastic#7439](elastic/eui#7439))
- Updated `EuiTextArea` to accept `isClearable` and `icon` as props
([elastic#7449](elastic/eui#7449))

**Bug fixes**

- `EuiRange`/`EuiDualRange`'s track ticks & highlights now update their
positions on resize ([elastic#7442](elastic/eui#7442))

**Deprecations**

- Updated `EuiFilterButton` to remove the second
`.euiFilterButton__textShift` span wrapper. Target
`.euiFilterButton__text` instead
([elastic#7444](elastic/eui#7444))

**Breaking changes**

- Removed deprecated `EuiNotificationEvent`. We recommend copying the
component to your application if necessary
([elastic#7434](elastic/eui#7434))
- Removed deprecated `EuiControlBar`. We recommend using `EuiBottomBar`
instead ([elastic#7435](elastic/eui#7435))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Bargs Bargs

Labels
Feature:Add Data Add Data and sample data feature on Home review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BigFunger @Bargs @alt74