[SECURITY_SOLUTION] Retry on ingest setup #75000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinlog
added
v8.0.0
v7.10.0
release_note:skip
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
kevinlog
added
the
Team:Endpoint Data Visibility
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
kevinlog
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
kevinlog
added
the
release_note:skip
michaelolo24
approved these changes
Aug 13, 2020
|
Looks good. On phone, so can’t approve it, but has my 👍
…--
___
*Paul Tavares *| Sr. Software Engineer | Elastic / www.elastic.co | Durham,
NC, USA
|
|
On second though - consider instead moving the use of `retry.try()` on the
ingest service instead of each of the test suites that use it. Seems like
the most appropriate thing to do.
--
…___
*Paul Tavares *| Sr. Software Engineer | Elastic / www.elastic.co | Durham,
NC, USA
|
james-elastic
approved these changes
Aug 14, 2020
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Aug 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 14, 2020
* master: Fix bug on TopN weird behavior with zero values (elastic#74942) [Lens] Fix table sorting bug (elastic#74902) [SECURITY_SOLUTION] Retry on ingest setup (elastic#75000) [file upload] lazy load to reduce page load size (elastic#74967) Drilldowns for TSVB / Vega / Timelion (elastic#74848) [EventLog] Populate alert instances view with event log data (elastic#68437) [UiActions] pass trigger into action execution context (elastic#74363)
kevinlog
added a commit
that referenced
this pull request
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ingestManager.setup();has failed on some tests, add a retry in case this happens.Checklist
Delete any items that are not applicable to this PR.