-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search][bug/tech debt] Fix route navigation #75369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate_breadcrumbs: - Change base breadcrumb generator to a custom React useHook instead of passing history/context around - Change use{Product}Breadcrumbs helpers to mainly involve merging arrays - Update + simplify tests accordingly (test link behavior in main useBreadcrumb suite, not in subsequent helpers) set_chrome: - Update to use new breadcrumb hooks (requires pulling out of useEffect, hooks can't be used inside another hook) - Clean up/refactor tests
To test that unmounting and mounting is not still happening, you can go here:
and add a |
scottybollinger
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Pulled it down locally and it works great. 🎉
cee-chen
pushed a commit
that referenced
this pull request
Aug 20, 2020
) * Set up navigateToUrl context * Update RR link helpers to use navigateToUrl * Update breadcrumbs to use navigateToUrl + refactor generate_breadcrumbs: - Change base breadcrumb generator to a custom React useHook instead of passing history/context around - Change use{Product}Breadcrumbs helpers to mainly involve merging arrays - Update + simplify tests accordingly (test link behavior in main useBreadcrumb suite, not in subsequent helpers) set_chrome: - Update to use new breadcrumb hooks (requires pulling out of useEffect, hooks can't be used inside another hook) - Clean up/refactor tests * Update route redirects now that navigation works correctly
thomasneirynck
pushed a commit
to thomasneirynck/kibana
that referenced
this pull request
Aug 21, 2020
* Set up navigateToUrl context * Update RR link helpers to use navigateToUrl * Update breadcrumbs to use navigateToUrl + refactor generate_breadcrumbs: - Change base breadcrumb generator to a custom React useHook instead of passing history/context around - Change use{Product}Breadcrumbs helpers to mainly involve merging arrays - Update + simplify tests accordingly (test link behavior in main useBreadcrumb suite, not in subsequent helpers) set_chrome: - Update to use new breadcrumb hooks (requires pulling out of useEffect, hooks can't be used inside another hook) - Clean up/refactor tests * Update route redirects now that navigation works correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks to some help from Josh Dover, Nathan Smith, and Pierre Gayvallet's original PR comment, I realized that our entire app was unmounting and remounting (also causing our Kea/Redux state to unmount & remount) on every in-app navigation when it should not have been.
This was happening because we were not using correctly Kibana's history navigation but instead directly accessing
history.push()
.This PR fixes all instances of
history.push()
tonavigateToUrl()
(and refactors our breadcrumbs helper to use hooks in order to simplify not passing around context). I recommend following along by commit.QA
enterpriseSearch.host
set:/engines
)enterpriseSearch.host
unset/commented out, from Kibana home:Checklist