Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Remove beta labels #75574

Merged
merged 4 commits into from
Aug 24, 2020
Merged

[Lens] Remove beta labels #75574

merged 4 commits into from
Aug 24, 2020

Conversation

wylieconlon
Copy link
Contributor

This removes the Beta labels from the Lens empty screen and the Visualize menu:

Screen Shot 2020-08-20 at 12 16 09 PM

Screen Shot 2020-08-20 at 12 16 20 PM

Part of making Lens GA #61453

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.10.0 labels Aug 20, 2020
@wylieconlon wylieconlon requested a review from a team August 20, 2020 16:18
@wylieconlon wylieconlon added this to In progress in Lens via automation Aug 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this pull request Aug 20, 2020
4 tasks
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this looks good to me, thanks for taking care of it.

Two things we should discuss, but can happen separately:

  • Not sure whether the description "Lens is a new tool for creating visualizations" still makes sense
  • We should think about removing the note about Lens being an app outside of Visualize

Screenshot 2020-08-21 at 14 06 17

@wylieconlon
Copy link
Contributor Author

@flash1293 One of those issues depends on #71919, cross-linking here

@wylieconlon wylieconlon added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 21, 2020
@wylieconlon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
lens 866.3KB -560.0B 866.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wylieconlon wylieconlon merged commit 3dea444 into elastic:master Aug 24, 2020
@wylieconlon wylieconlon deleted the lens/ga branch August 24, 2020 16:07
wylieconlon pushed a commit that referenced this pull request Aug 24, 2020
* [Lens] Remove beta labels

* Remove translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@wylieconlon wylieconlon moved this from In progress to Done in Lens Aug 26, 2020
parkiino pushed a commit to parkiino/kibana that referenced this pull request Sep 1, 2020
* [Lens] Remove beta labels

* Remove translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
No open projects
Lens
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants